-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore (global.db): Test consistency with updates #7947
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #7947 +/- ##
=============================================
- Coverage 80.26% 63.23% -17.03%
=============================================
Files 1098 654 -444
Lines 106799 53451 -53348
Branches 13360 9515 -3845
=============================================
- Hits 85717 33798 -51919
+ Misses 18995 17724 -1271
+ Partials 2087 1929 -158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Left some initial comments. Perhaps it will make sense also for yabir to look at this as he also worked a lot on the assets.
-
Related tests failed and need fixing
-
I would put all this test code in a different file and common utilities (if needed) in a utils files under tests
c4fa5ed
to
36a73b9
Compare
62d32a1
to
492ffbf
Compare
d87e347
to
f98c03a
Compare
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes:
SQL diff: