Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: Add repository to solver problem messages #1464

Merged
merged 4 commits into from
May 27, 2024

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Apr 30, 2024

Information about the repository is important for debugging, especially
for systems where packages may originate from different repositories.

Resolves: #1123

Tests adjustments: rpm-software-management/ci-dnf-stack#1500

@j-mracek j-mracek self-assigned this Apr 30, 2024
@m-blaha m-blaha marked this pull request as ready for review May 2, 2024 07:39
@m-blaha m-blaha marked this pull request as draft May 2, 2024 07:40
@m-blaha m-blaha force-pushed the mblaha/libsolv-errors-repoid branch from 5bf7db3 to f67f850 Compare May 2, 2024 09:41
@m-blaha m-blaha marked this pull request as ready for review May 2, 2024 11:16
@m-blaha m-blaha force-pushed the mblaha/libsolv-errors-repoid branch from 7825395 to 1e0d3c1 Compare May 22, 2024 07:01
Information about the repository is important for debugging, especially
for systems where packages may originate from different repositories.
Do not include the "pkgA conflicts with pkgB" message in case the "pkgB
conflicts with pkgA" message is already present.
Instead of cryptic "PkgA from @System" is used more user friendli
expression "installed package PkgA".
@m-blaha m-blaha force-pushed the mblaha/libsolv-errors-repoid branch from 1e0d3c1 to cc76aad Compare May 22, 2024 13:28
@j-mracek
Copy link
Member

LGTM

@j-mracek j-mracek added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 161e050 May 27, 2024
10 of 15 checks passed
@j-mracek j-mracek deleted the mblaha/libsolv-errors-repoid branch May 27, 2024 09:28
@j-mracek
Copy link
Member

Tested locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNF5 does not report repository name in libsolv errors.
2 participants