conf: New classes for append options #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/append-option-2
branch
3 times, most recently
from
8132629
to
71bcf4a
Compare
jan-kolarik
reviewed
May 27, 2024
Good point. I will add more tests. |
Introducing `OptionStringAppendList` and `OptionStringAppendSet` classes for append options. The current implementation of append options is flawed because it requires the options to be set in ascending order of priority for proper functionality. This is necessary for the resetting mechanism using an empty item to work correctly. However, in dnf5, options are not processed strictly in priority order. For instance, command line options like `--exclude` are processed before the configuration files, despite having a higher priority than config files. The new classes accumulate all setting attempts and then process them in priority order to compute the actual value.
Converted main options: - excludepkgs - includepkgs - installonlypkgs - optional_metadata_types - protected_packages - tsflags Converted repository options: - excludepkgs - includepkgs - protected_packages
- Add couple of tests of append option behavior - Fix Python config option unittest
m-blaha
force-pushed
the
mblaha/append-option-2
branch
from
71bcf4a
to
c6e518e
Compare
jan-kolarik
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
OptionStringAppendListandOptionStringAppendSetclassesfor append options.
The current implementation of append options is flawed because it requires
the options to be set in ascending order of priority for proper
functionality. This is necessary for the resetting mechanism using an empty
item to work correctly. However, in dnf5, options are not processed
strictly in priority order. For instance, command line options like
--excludeare processed before the configuration files, despite having ahigher priority than config files.
The new classes accumulate all setting attempts and only process them in
priority order when the option value is needed.
Resolves: #1331