Added de-duplication for environment list print #1503
Conversation
Previously, `dnf5 environment list` would print duplicate environment with the same id and name. It would be confusing for the user to see duplicate environment names. This patch introduces de-duplication for the environment list print feature to merge duplicate environment entries. The original order of the environments is preserved by assigning an index value to each environment entry. Fixes: rpm-software-management#1502
|
Hi, thanks for the patch! I agree it should be de-duplicated, but I'd rather have the code same as the one for the groups where it's in the dnf5/commands part: https://github.com/rpm-software-management/dnf5/blob/main/dnf5/commands/group/group_list.cpp#L73-L84 . It will be easier to maintain. I also wanted to say that another advantage is that the de-duplication will work for both list and info, but unfortunately, the environment command doesn't reuse the list subcommand in the same way as group command does. But that's something we should change as well, though, it's not necessary to resolve in this PR, I can create a follow-up issue. |
|
Thanks for the feedback. I appreciate it. I recognize that my solution in this PR isn't perfect, even from my own perspective. I'll take another look at it when I get a chance and see if I can improve it. |
Previously,
dnf5 environment listwould print duplicate environment with the same id and name. It would be confusing for the user to see duplicate environment names. This patch introduces de-duplication for the environment list print feature to merge duplicate environment entries. The original order of the environments is preserved by assigning an index value to each environment entry.Fixes: #1502