Add send_add_queue_command to dynamically add listening queue #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add send_add_queue_command to dynamically add listening queue
selwin
reviewed
Sep 28, 2021
| @@ -492,6 +492,17 @@ def _shutdown(self): | |||
| def handle_warm_shutdown_request(self): | |||
| self.log.info('Warm shut down requested') | |||
|
|
|||
| def add_queue(self, queue): | |||
| self.log.info(f'Asked to add queue: {queue}') | |||
| found = False | |||
There was a problem hiding this comment.
What happens if the worker is currently blocking and waiting for a job to arrive in the current queue? In this case I think the worker should stop waiting and restart the process of waiting for jobs to arrive in self.queues.
There was a problem hiding this comment.
You are correct but I didn’t found a clean way for doing it. In my test environment I just lowered worker ttl but of course if workers are constantly busy the new queues will not be processed.
There was a problem hiding this comment.
Yeah, so I think before we can get this in, we need to implement a way for the worker to stop waiting for jobs to arrive.
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this PR to be able to add dynamically Queues to Workers sending a command to the relevant ones.
I also exposed Job from rq module directly (as Queue and Worker) and added RoundRobinWorker.