Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connection max retries #1827

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

ccrvlh
Copy link
Collaborator

@ccrvlh ccrvlh commented Feb 20, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 95.03% // Head: 95.00% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (3f3b17e) compared to base (aedc9b9).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   95.03%   95.00%   -0.04%     
==========================================
  Files          51       51              
  Lines        7877     7884       +7     
==========================================
+ Hits         7486     7490       +4     
- Misses        391      394       +3     
Impacted Files Coverage Δ
rq/worker.py 88.07% <50.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -235,7 +235,8 @@ def __init__(
disable_default_exception_handler: bool = False,
prepare_for_work: bool = True,
serializer=None,
work_horse_killed_handler: Optional[Callable[[Job, int, int, resource.struct_rusage], None]] = None
work_horse_killed_handler: Optional[Callable[[Job, int, int, resource.struct_rusage], None]] = None,
connection_max_retries: int = -1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be made an argument for work() similar to burst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants