feat: option to disable scheduler in WorkerPool #2059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
optional_scheduler
branch
from
aa76a63
to
806461c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
+ Coverage 93.61% 93.90% +0.28%
==========================================
Files 28 30 +2
Lines 3758 3969 +211
==========================================
+ Hits 3518 3727 +209
- Misses 240 242 +2 ☔ View full report in Codecov by Sentry. |
ankush
force-pushed
the
optional_scheduler
branch
3 times, most recently
from
5390a72
to
7a178aa
Compare
ankush
force-pushed
the
optional_scheduler
branch
from
ff5d921
to
9327fdb
Compare
ankush
commented
Mar 16, 2024
selwin
reviewed
Mar 23, 2024
|
@selwin anything left from my side? 👀 |
selwin
reviewed
Apr 12, 2024
|
Sorry for the delayed response, just left a minor comment. |
ankush
force-pushed
the
optional_scheduler
branch
from
3c05d28
to
a953d29
Compare
|
Reopen if required, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flag mentioned here: #2027 (comment)
Why do this?
We have our own scheduler, so we'd prefer to not enable RQ's scheduler until we have migrated to it. This PR just helps avoid some overhead from the scheduler process.
TODO: