Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Make IpldDag and Ipns async_traits #285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make IpldDag and Ipns async_traits #285

wants to merge 2 commits into from

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Aug 5, 2020

This was a part of #264 which was surprisingly painless and seems more idiomatic than the current approach of creating ad-hoc intermediate structs containing an Ipfs (which is internally an Arc).

@ljedrz
feat: make IpldDag an async_trait
c6952cb 
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz ljedrz requested a review from koivunej August 5, 2020 10:40
@ljedrz
Copy link
Member Author

ljedrz commented Aug 5, 2020

Oof, forgot the tests 😄.

@ljedrz ljedrz marked this pull request as draft August 5, 2020 10:45
@ljedrz
feat: make Ipns an async_trait
aca0b14 
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz ljedrz marked this pull request as ready for review August 5, 2020 11:00
koivunej
koivunej reviewed Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure if we need to go into this direction, at least yet (as discussed). Apart from async_trait, we could see if pollable-async-trait could be used but lets consider this later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koivunej koivunej koivunej left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ljedrz @koivunej