ActiveJob performed matchers #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacseymour
force-pushed
the
activejob-performed-matchers
branch
from
627d979
to
d574bc3
Compare
BobbyMcWho
reviewed
Oct 16, 2018
BobbyMcWho
reviewed
Oct 16, 2018
JonRowe
reviewed
Jan 15, 2019
JonRowe
requested changes
Jan 15, 2019
pirj
force-pushed
the
activejob-performed-matchers
branch
from
495a21e
to
3ad3f0a
Compare
pirj
reviewed
Dec 11, 2019
benoittgt
approved these changes
Dec 13, 2019
|
Also squashed commits. |
|
Squashed on @isaacseymour's branch, but that did not update the PR 8E |
pirj
force-pushed
the
activejob-performed-matchers
branch
from
ec14c6c
to
b3ec8c9
Compare
JonRowe
requested changes
Dec 14, 2019
pirj
force-pushed
the
activejob-performed-matchers
branch
from
bcf77ba
to
db5696b
Compare
JonRowe
approved these changes
Dec 17, 2019
|
@isaacseymour could you rebase? We fixed the CI. |
* `have_been_performed` is like `have_been_enqueued`, but for performed jobs * `have_performed_job`/`perform_job` is like `have_enqueued_job`/`enqueue_job`, but for performed jobs
|
Rebased 👍 |
pirj
force-pushed
the
activejob-performed-matchers
branch
from
db5696b
to
56f6387
Compare
|
@pirj I didn't you can rebase and push from a fork you don't own. 🤔 |
|
It seems it's possible by default with this setting: |
|
Thanks! Good to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have_been_performedis likehave_been_enqueued, but for performedjobs
have_performed_jobis likehave_enqueued_job, but for performedjobs
It's somewhat unusual to use
perform_enqueued_jobs, but it seems nice ifrspec-rails supports it!