New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveJob performed matchers #1785
ActiveJob performed matchers #1785
Conversation
627d979
to
d574bc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase to see if we can get a green build here...
495a21e
to
3ad3f0a
Compare
Also squashed commits. |
Squashed on @isaacseymour's branch, but that did not update the PR 8E |
ec14c6c
to
b3ec8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few tweaks / queries left
bcf77ba
to
db5696b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge when green, don't forget a changelog
@isaacseymour could you rebase? We fixed the CI. |
* `have_been_performed` is like `have_been_enqueued`, but for performed jobs * `have_performed_job`/`perform_job` is like `have_enqueued_job`/`enqueue_job`, but for performed jobs
Rebased 👍 |
db5696b
to
56f6387
Compare
@pirj I didn't you can rebase and push from a fork you don't own. 🤔 |
Thanks! Good to know. |
have_been_performed
is likehave_been_enqueued
, but for performedjobs
have_performed_job
is likehave_enqueued_job
, but for performedjobs
It's somewhat unusual to use
perform_enqueued_jobs
, but it seems nice ifrspec-rails supports it!