Fix `WrongScopeError` being thrown on Rails master: #2215

Edouard-chin · 2019-12-02T14:33:09Z

Fix WrongScopeError being thrown on Rails master:

Problem

Rails made a change in rails/rails@d4367eb
and TestFixtures don't make use of method_name anymore, but simply
name.

name on RSpec raises a WrongScopeError when called within an
example.

This patch overrides name to return the example name instead.

jasnow · 2019-12-02T14:55:18Z

Appears the fix triggered an existing rubocop error.

lib/rspec/rails/fixture_support.rb

JonRowe

A minor change suggested, and is there a test that fails without this?

Edouard-chin · 2019-12-04T14:25:33Z

Thanks for the quick review. I made the suggested changes

JonRowe · 2019-12-04T15:48:53Z

lib/rspec/rails/fixture_support.rb

@@ -50,6 +50,12 @@ def self.proxy_method_warning_if_called_in_before_context_scope(method_name)
            end
          end

+          if ::ActiveRecord.version >= Gem::Version.new('6.1.0')


Sorry you can't use Gem::Version, as we don't have a dependency on rubygems being available. A simple

Suggested change

if ::ActiveRecord.version >= Gem::Version.new('6.1.0')

if Rails.version.to_f > 6.0

is preferred.

Rubygem is part of the standard library since ruby 1.9. I can use Rails.version.to_f if you really want to but I don't see any real reason

We don't load any part of the standard library unless 100% necessary as it causes environment poisoning (where someone might not have required the right file but we do, tests pass, but it fails outside of tests). There is also a speed benefit to not using rubygems which we ourselves utilise in our tests by disabling it (which gives us the speed benefit and tests we're not poisoning the env).

e.g Its simpler to not use it so please don't :)

Ok I'll use Rails.version.to_f, thanks for quick answer :)

Not trying to argue on such a small detail but Rails.version already loads rubygem 🤷‍♂ . But anyway having the syntax you proposed will make things consistent since that's what it's used in this library.

JonRowe · 2019-12-04T15:49:24Z

spec/rspec/rails/fixture_support_spec.rb

@@ -13,5 +13,15 @@ module RSpec::Rails
        expect(group).to respond_to(:fixture_path=)
      end
    end
+
+    it "doesn't raise a WrongScopeError on Rails 6.1" do
+      allow(ActiveRecord).to receive(:version) { Gem::Version.new('6.1.0') }


Proposed change removes this necessity

spec/rspec/rails/fixture_support_spec.rb

JonRowe · 2019-12-05T20:23:02Z

If you rebase this the rubocop build should be fixed

jasnow · 2019-12-08T13:35:10Z

@Edouard-chin - Looking forward to this fixed version.

chaadow · 2019-12-09T16:30:07Z

+1

lib/rspec/rails/fixture_support.rb

jasnow · 2019-12-11T16:18:49Z

Rails::VERSION::STRING.to_f

Edouard-chin · 2019-12-11T17:15:48Z

Not too sure what's up with the jruby builds, otherwise it's 🍏

pirj · 2019-12-11T17:16:54Z

flori/json#392

benoittgt · 2019-12-11T20:26:29Z

Thanks @pirj. I just reran the 2 builds, the issue on json seems to be fixed now.

benoittgt · 2019-12-12T14:43:55Z

@Edouard-chin thanks a lot for the last commit. Do you think you can handle @JonRowe review?

Thanks :)

Edouard-chin · 2019-12-12T16:12:24Z

Do you think you can handle @JonRowe review?

Sure happy to, but which comment did I not address ? If you are referring to #2215 (comment) I added a test to load fixtures

benoittgt · 2019-12-13T08:01:40Z

Sorry @Edouard-chin. I just noticed. @JonRowe are you ok with the last changes?

Cheers :)

JonRowe · 2019-12-14T12:12:42Z

spec/rspec/rails/fixture_support_spec.rb

+      end
+
+      expect { group.new.name }.to_not raise_error
+    end


This test can be removed, the other is fine.

spec/rspec/rails/fixture_support_spec.rb

JonRowe

Nearly there, thanks for working on this!

Edouard-chin · 2019-12-24T15:04:38Z

Rebased and CI is 🍏 . Thanks for your patience

Fix `WrongScopeError` being thrown on Rails master:

Related errors below. == Test WrongScopeError Error: ``` Failures: 1) Posts API (Custom Controller) GET /posts returns a list of posts Failure/Error: raise WrongScopeError, "`#{name}` is not available from within an example (e.g. an " \ "`it` block) or from constructs that run in the scope of an " \ "example (e.g. `before`, `let`, etc). It is only available " \ "on an example group (e.g. a `describe` or `context` block)." `name` is not available from within an example (e.g. an `it` block) or from constructs that run in the scope of an example (e.g. `before`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block). # /Users/alexkitchens/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/example_group.rb:742:in `method_missing' # /Users/alexkitchens/fun/journey/dependencies/rails/actionpack/lib/action_dispatch/testing/assertions/routing.rb:188:in `method_missing' # /Users/alexkitchens/fun/journey/dependencies/rails/actionpack/lib/action_dispatch/testing/integration.rb:422:in `method_missing' # /Users/alexkitchens/fun/journey/dependencies/rails/activerecord/lib/active_record/test_fixtures.rb:101:in `run_in_transaction?' # /Users/alexkitchens/fun/journey/dependencies/rails/activerecord/lib/active_record/test_fixtures.rb:115:in `setup_fixtures' # /Users/alexkitchens/fun/journey/dependencies/rails/activerecord/lib/active_record/test_fixtures.rb:8:in `before_setup' # /Users/alexkitchens/fun/journey/dependencies/rails/actionpack/lib/action_dispatch/testing/integration.rb:331:in `before_setup' # /Users/alexkitchens/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rspec-rails-3.8.2/lib/rspec/rails/adapters.rb:126:in `block (2 levels) in <module:MinitestLifecycleAdapter>' # /Users/alexkitchens/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/example.rb:447:in `instance_exec' # /Users/alexkitchens/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/example.rb:447:in `instance_exec' # /Users/alexkitchens/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rspec-core-3.8.0/lib/rspec/core/hooks.rb:373:in `execute_with' # # Showing full backtrace because every line was filtered out. # See docs for RSpec::Configuration#backtrace_exclusion_patterns and # RSpec::Configuration#backtrace_inclusion_patterns for more information. ``` Bisect led to d4367eb72601f6e5bba3206443e9d141e9753af8 Issue opened here: rails/rails#37783 Fix in Rspec Rails here: rspec/rspec-rails#2215 The fix is not in a full release yet, so I've pinned to the latest beta release. ``` commit d4367eb72601f6e5bba3206443e9d141e9753af8 Author: Edouard CHIN <edouard.chin@shopify.com> Date: Thu Nov 21 18:39:54 2019 +0100 Modify ActiveRecord::TestFixtures to not rely on AS::TestCase: - ### Problem If one wants to use ActiveRecord::TestFixtures it is mandatory for the test suite to inherit from `ActiveSupport::TestCase`. TestFixtures makes use of specific method from AS::TestCase (`file_fixture_path` and `method_name`). ### Solution This PR fixes that by not making use of method_name and file_fixture_path. ``` == Time Issue Error: ``` Failure/Error: require File.expand_path('../../config/environment', __FILE__) NoMethodError: undefined method `hour' for 1:Integer Run options: include {:locations=>{"./spec/requests/api/posts_spec.rb"=>[10]}} ``` Bisect led to commit 12959dee0f19a8e050dd1236b031c2c690729905 Issue open at rails/rails#37391

Rails 6.1 requires an upgrade to rspec-rails 4.0.0 which fixes a WrongScopeError: rspec/rspec-rails#2215 Rspec-rails 4.0.0 dropped support for Rails below 5.0, so Rails 4 has been removed from the appraisals.

It seems like rails 6.1 broke rspec <4.0 until it was fixed with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec 3x with rails 6.1 in CI

It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI

Some of the missing combinations in the matrix: * Ruby 3 with Rails 5.2 are skipped because my tests error when trying to start rails * Rspec-rails 3 with Rails 6.1 because of a rails change rspec-rails needs rspec/rspec-rails#2215 or the more recent rspec/rspec-rails#2461

There's an issue with Rails 6.1 that caused error `WrongScopeError`, which was only fixed in rspec-rails 4.0 by rspec#2215.

Edouard-chin mentioned this pull request Dec 2, 2019

WrongScopeError exception with edge rails rails/rails#37783

Closed

pirj mentioned this pull request Dec 2, 2019

Pin RuboCop to avoid failures due to renamed cops #2216

Merged

JonRowe reviewed Dec 3, 2019

View reviewed changes

lib/rspec/rails/fixture_support.rb Outdated Show resolved Hide resolved

JonRowe requested changes Dec 3, 2019

View reviewed changes

Edouard-chin force-pushed the ec-rails-master branch from 5bfbfff to 12b0e5d Compare December 4, 2019 14:25

JonRowe reviewed Dec 4, 2019

View reviewed changes

spec/rspec/rails/fixture_support_spec.rb Outdated Show resolved Hide resolved

JonRowe requested changes Dec 4, 2019

View reviewed changes

spec/rspec/rails/fixture_support_spec.rb Outdated Show resolved Hide resolved

Edouard-chin force-pushed the ec-rails-master branch 2 times, most recently from a428956 to 4f980ff Compare December 9, 2019 18:57

benoittgt reviewed Dec 11, 2019

View reviewed changes

lib/rspec/rails/fixture_support.rb Show resolved Hide resolved

Edouard-chin force-pushed the ec-rails-master branch from 4f980ff to 0507fc2 Compare December 11, 2019 16:33

JonRowe reviewed Dec 14, 2019

View reviewed changes

spec/rspec/rails/fixture_support_spec.rb Outdated Show resolved Hide resolved

JonRowe reviewed Dec 14, 2019

View reviewed changes

spec/rspec/rails/fixture_support_spec.rb Outdated Show resolved Hide resolved

JonRowe requested changes Dec 14, 2019

View reviewed changes

Edouard-chin force-pushed the ec-rails-master branch from a187433 to 921e67d Compare December 16, 2019 11:08

JonRowe merged commit 43e52bf into rspec:master Dec 24, 2019

JonRowe added a commit that referenced this pull request Dec 25, 2019

Changelog for #2215

a11617e

JonRowe added a commit that referenced this pull request Jan 12, 2020

Merge pull request #2215 from Edouard-chin/ec-rails-master

09aab18

Fix `WrongScopeError` being thrown on Rails master:

JonRowe added a commit that referenced this pull request Jan 12, 2020

Changelog for #2215

9700a5a

pirj mentioned this pull request Mar 6, 2020

Add configuration to surpress active_record checks #2266

Merged

This was referenced Dec 21, 2020

WrongScopeError: name when use_active_record = false #2417

Closed

Fix WrongScopeError #2423

Merged

pirj added this to the 4.1 milestone Dec 24, 2020

p8 mentioned this pull request Jan 9, 2021

Add appraisals for Rails 6.1 collectiveidea/awesome_nested_set#442

Merged

benoittgt mentioned this pull request Jan 13, 2021

Repro name scope error in a Rails file app #2445

Closed

guigs added a commit to guigs/rspec-rails that referenced this pull request Mar 2, 2021

Prevent using 3.9 with Rails 6.1

fee5baf

There's an issue with Rails 6.1 that caused error `WrongScopeError`, which was only fixed in rspec-rails 4.0 by rspec#2215.

guigs mentioned this pull request Mar 2, 2021

Prevent using 3.9 with Rails 6.1 #2473

Closed

eugeneius mentioned this pull request Feb 19, 2024

Fix failing fixture support test on Rails main #2733

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `WrongScopeError` being thrown on Rails master: #2215

Fix `WrongScopeError` being thrown on Rails master: #2215

Edouard-chin commented Dec 2, 2019

jasnow commented Dec 2, 2019

JonRowe left a comment

Edouard-chin commented Dec 4, 2019

JonRowe Dec 4, 2019

Edouard-chin Dec 9, 2019

JonRowe Dec 9, 2019

JonRowe Dec 9, 2019

Edouard-chin Dec 9, 2019

JonRowe Dec 4, 2019

JonRowe commented Dec 5, 2019

jasnow commented Dec 8, 2019

chaadow commented Dec 9, 2019

jasnow commented Dec 11, 2019

Edouard-chin commented Dec 11, 2019

pirj commented Dec 11, 2019

benoittgt commented Dec 11, 2019

benoittgt commented Dec 12, 2019

Edouard-chin commented Dec 12, 2019

benoittgt commented Dec 13, 2019

JonRowe Dec 14, 2019

JonRowe left a comment

Edouard-chin commented Dec 24, 2019

	if ::ActiveRecord.version >= Gem::Version.new('6.1.0')
	if Rails.version.to_f > 6.0

Fix WrongScopeError being thrown on Rails master: #2215

Fix WrongScopeError being thrown on Rails master: #2215

Conversation

Edouard-chin commented Dec 2, 2019

Problem

jasnow commented Dec 2, 2019

JonRowe left a comment

Choose a reason for hiding this comment

Edouard-chin commented Dec 4, 2019

JonRowe Dec 4, 2019

Choose a reason for hiding this comment

Edouard-chin Dec 9, 2019

Choose a reason for hiding this comment

JonRowe Dec 9, 2019

Choose a reason for hiding this comment

JonRowe Dec 9, 2019

Choose a reason for hiding this comment

Edouard-chin Dec 9, 2019

Choose a reason for hiding this comment

JonRowe Dec 4, 2019

Choose a reason for hiding this comment

JonRowe commented Dec 5, 2019

jasnow commented Dec 8, 2019

chaadow commented Dec 9, 2019

jasnow commented Dec 11, 2019

Edouard-chin commented Dec 11, 2019

pirj commented Dec 11, 2019

benoittgt commented Dec 11, 2019

benoittgt commented Dec 12, 2019

Edouard-chin commented Dec 12, 2019

benoittgt commented Dec 13, 2019

JonRowe Dec 14, 2019

Choose a reason for hiding this comment

JonRowe left a comment

Choose a reason for hiding this comment

Edouard-chin commented Dec 24, 2019

Fix `WrongScopeError` being thrown on Rails master: #2215

Fix `WrongScopeError` being thrown on Rails master: #2215