Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WrongScopeError being thrown on Rails master: #2215

Merged
merged 1 commit into from Dec 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/rspec/rails/fixture_support.rb
Expand Up @@ -39,6 +39,12 @@ def self.proxy_method_warning_if_called_in_before_context_scope(method_name)
end
end

if ::Rails.version.to_f >= 6.1
benoittgt marked this conversation as resolved.
Show resolved Hide resolved
def name
@example
end
end

fixtures RSpec.configuration.global_fixtures if RSpec.configuration.global_fixtures
end
end
Expand Down
8 changes: 6 additions & 2 deletions spec/rspec/rails/configuration_spec.rb
Expand Up @@ -196,7 +196,9 @@ def in_inferring_type_from_location_environment

it "metadata `type: :request` sets up request example groups" do
a_rails_app = double("Rails application")
the_rails_module = Module.new
the_rails_module = Module.new {
def self.version; end;
}
allow(the_rails_module).to receive(:application) { a_rails_app }
version = ::Rails::VERSION
stub_const "Rails", the_rails_module
Expand Down Expand Up @@ -230,7 +232,9 @@ def in_inferring_type_from_location_environment

it "metadata `type: :feature` sets up feature example groups" do
a_rails_app = double("Rails application")
the_rails_module = Module.new
the_rails_module = Module.new {
def self.version; end;
}
allow(the_rails_module).to receive(:application) { a_rails_app }
version = ::Rails::VERSION
stub_const "Rails", the_rails_module
Expand Down
11 changes: 11 additions & 0 deletions spec/rspec/rails/fixture_support_spec.rb
Expand Up @@ -13,5 +13,16 @@ module RSpec::Rails
expect(group).to respond_to(:fixture_path=)
end
end

it "will allow #setup_fixture to run successfully", if: Rails.version.to_f > 6.0 do

group = RSpec::Core::ExampleGroup.describe do
include FixtureSupport

self.use_transactional_tests = false
end

expect { group.new.setup_fixtures }.to_not raise_error
end
end
end