Relax maximum capybara version constraint #2281
Conversation
| @@ -48,7 +48,7 @@ gem 'rake', '~> 12' | |||
|
|
|||
| gem 'mime-types', "~> 3" | |||
|
|
|||
| gem 'capybara', '~> 2.13', require: false | |||
| gem 'capybara', '>= 2.13', '< 4.0', require: false | |||
There was a problem hiding this comment.
Checked locally, rake is green with the latest Capybara 3.x.
Changes:
-
Capybara 3 changes the default server to Puma (doc)
This is pretty much up to the users,rspec-railsdon't depend on either. -
Finders (doc)
Up to the users as well, we don't wrapfirst/all. -
Node (doc)
We don't wrap those methods, so it's up to the users.
Update of Capybara to 3.x will only happen when Rails hits 6.1 (or when Rails will decide to bump Capybara to 3.x), and Rails' 6.0 -> 6.1 update docs should pretty much cover it.
| @@ -366,7 +366,7 @@ you can run the specs and Cucumber features, or submit a pull request. | |||
| ### Recommended third-party extensions | |||
|
|
|||
| * [FactoryBot](https://github.com/thoughtbot/factory_bot) | |||
| * [Capybara](https://github.com/jnicklas/capybara) | |||
| * [Capybara](https://github.com/teamcapybara/capybara) | |||
| @@ -48,7 +48,7 @@ gem 'rake', '~> 12' | |||
|
|
|||
| gem 'mime-types', "~> 3" | |||
|
|
|||
| gem 'capybara', '~> 2.13', require: false | |||
| gem 'capybara', '>= 2.13', '< 4.0', require: false | |||
There was a problem hiding this comment.
I'd still prefer '~> 2.13', '~> 3.0' its semantically the same but a bit clearer in my opinion. Unless its not valid for some reason?
There was a problem hiding this comment.
Bundler seems to combine the options passed with "and", so this fails with:
Could not find gem 'capybara (~> 2.13, ~> 3.0)' in any of the gem sources listed in your Gemfile.
Relax maximum capybara version constraint
fixes #1095