-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax maximum capybara version constraint #2281
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,7 @@ gem 'rake', '~> 12' | |
|
||
gem 'mime-types', "~> 3" | ||
|
||
gem 'capybara', '~> 2.13', require: false | ||
gem 'capybara', '>= 2.13', '< 4.0', require: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd still prefer There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bundler seems to combine the options passed with "and", so this fails with:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair enough! |
||
|
||
if MAJOR < 6 | ||
gem 'nokogiri', '1.9.1' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -366,7 +366,7 @@ you can run the specs and Cucumber features, or submit a pull request. | |
### Recommended third-party extensions | ||
|
||
* [FactoryBot](https://github.com/thoughtbot/factory_bot) | ||
* [Capybara](https://github.com/jnicklas/capybara) | ||
* [Capybara](https://github.com/teamcapybara/capybara) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
(Included by default in Rails 5.1+. | ||
Note that [additional configuration is required][] to use the Capybara DSL | ||
anywhere other than system specs and feature specs.) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked locally,
rake
is green with the latest Capybara 3.x.Changes:
Capybara 3 changes the default server to Puma (doc)
This is pretty much up to the users,
rspec-rails
don't depend on either.Finders (doc)
Up to the users as well, we don't wrap
first
/all
.Node (doc)
We don't wrap those methods, so it's up to the users.
Update of Capybara to 3.x will only happen when Rails hits 6.1 (or when Rails will decide to bump Capybara to 3.x), and Rails' 6.0 -> 6.1 update docs should pretty much cover it.