Add support for Rails engines routes in request specs #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
changed the title
|
I guess we'll need a spec for that. |
klyonrad
suggested changes
Aug 21, 2020
JonRowe
reviewed
Aug 24, 2020
|
Great start thanks for tackling, we usually test generators by running them in the example app, tweaking with removing comments etc and then letting them pass |
|
Thanks for the feedback everyone. I was trying to get a reproducable test case so have been working on that. |
JonRowe
requested changes
Aug 26, 2020
Currently, when scaffolds are generated inside a Rails Engine, it generates requests specs that fail without modification. This happens because the Engine routes are not mounted under Rails.application. To fix this, Engine routes have to be included so that url and path helpers can be usable from within the spec file.
|
@JonRowe I've added a test to make sure the route helpers get included. Wanted to get your thoughts on the namespaced include engine route/url helpers -- it looks like Rails generators does not do that, so does it make sense to keep it similar? |
JonRowe
approved these changes
Aug 27, 2020
|
Thanks! |
This was referenced Mar 7, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when scaffolds are generated inside a Rails Engine, it generates requests specs that fail without modification. This happens because the Engine routes are not mounted under Rails.application.
To fix this, Engine routes have to be included so that url and path helpers can be usable from within the spec file.