Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails engines routes in request specs #2372

Merged
merged 6 commits into from Aug 27, 2020
Merged

Add support for Rails engines routes in request specs #2372

merged 6 commits into from Aug 27, 2020

Commits on Aug 26, 2020

  1. Update request spec scaffold template 

    Currently, when scaffolds are generated inside a Rails Engine, it generates requests specs that fail without modification. This happens because the Engine routes are not mounted under Rails.application.

To fix this, Engine routes have to be included so that url and path helpers can be usable from within the spec file.
    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    e697a1e View commit details
    Browse the repository at this point in the history

  2. Fix engine route include statement

    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    e8161a7 View commit details
    Browse the repository at this point in the history

  3. Add cucumber test for engine routes

    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    f044207 View commit details
    Browse the repository at this point in the history

  4. Update feature test with PR feedback

    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    b634f35 View commit details
    Browse the repository at this point in the history

  5. Move feature test into request_spec file

    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    4633133 View commit details
    Browse the repository at this point in the history

  6. Add spec for including engine routes

    @drwl
    drwl committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    384caac View commit details
    Browse the repository at this point in the history