Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IntegrationGenerator #2374

Closed
klyonrad opened this issue Aug 21, 2020 · 1 comment · Fixed by #2387
Closed

Deprecate IntegrationGenerator #2374

klyonrad opened this issue Aug 21, 2020 · 1 comment · Fixed by #2387

Comments

@klyonrad
Copy link
Contributor

Is your ticket related to a problem? Please describe.

There is a IntegrationGenerator class and the code comments mention something about "deprecation for this class before rspec-rails 4". I read the commit message and I don't quite understand if it is technically necessary or not? That's why I am opening this ticket for discussion/explanation 🤔

Maybe if we delete the class (and the shared examples) we could reduce the development complexity about generators a bit.

From a user perspective I would say that having that integration generator options is just a bit confusing.

Additional context

#1378

@JonRowe
Copy link
Member

JonRowe commented Aug 24, 2020

We can't delete it now it's made it into rspec-rails 4.0.0 but we should deprecate it and remove it in rspec-rails 5.0.0

@JonRowe JonRowe changed the title Delete IntegrationGenerator? Deprecate IntegrationGenerator Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants