Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration generator deprecation #2387

Merged
merged 5 commits into from Jul 17, 2022

Conversation

klyonrad
Copy link
Contributor

@klyonrad klyonrad commented Sep 25, 2020

Closes #2374

With these changes executing rails generate rspec:integration produces the following message

DEPRECATION: 
  The integration generator is deprecated and will be deleted in RSpec-Rails 5. Please use the request generator instead.
 Called from ...../rspec-rails/lib/generators/rspec/integration/integration_generator.rb:18:in `generate_request_spec'

Test Plan

rake generate:app
cd tmp/example_app/
rails generate rspec:integration Bottles
# DEPRECATION: 
#  IntegrationGenerator is deprecated and will be deleted in RSpec 5. Please use `rspec:generator` instead. It should behave in the same way.
# Called from .../rspec-rails/lib/generators/rspec/integration/integration_generator.rb:18:in `generate_request_spec'.
#      create  spec/requests/bottles_spec.rb
rails generate rspec:request Bottles
#    identical  spec/requests/bottles_spec.rb

@klyonrad
Copy link
Contributor Author

TODO: test out the scaffolds generation

@klyonrad klyonrad force-pushed the integration-generator-deprecation branch from 82f211e to 7b47f79 Compare October 11, 2020 09:09
Copy link
Contributor Author

@klyonrad klyonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the scaffold integration: Fine ✔️

I tried the test suite out what happens lib/generators/rspec/integration/integration_generator.rb is deleted. This helped to catch the now unnecessary require 'generators/rspec/integration/integration_generator' statement 😁

@klyonrad klyonrad force-pushed the integration-generator-deprecation branch from 7b47f79 to 3b6f8f0 Compare October 17, 2020 15:10
@klyonrad klyonrad marked this pull request as ready for review October 17, 2020 15:10
@klyonrad klyonrad force-pushed the integration-generator-deprecation branch from 3b6f8f0 to 6d75158 Compare October 17, 2020 15:25
@klyonrad klyonrad requested a review from JonRowe October 17, 2020 15:44
@JonRowe JonRowe mentioned this pull request Jan 18, 2022
21 tasks
and break the inheritance.
IntegrationGenerator will get a deprecation
so the inheritance made no sense.
@pirj pirj force-pushed the integration-generator-deprecation branch from 6d75158 to 0b29fdd Compare July 17, 2022 18:33
@pirj pirj dismissed JonRowe’s stale review July 17, 2022 18:46

Notes addressed

@pirj pirj force-pushed the integration-generator-deprecation branch from 0b29fdd to fe42d6b Compare July 17, 2022 19:01
@pirj pirj merged commit b6a4bdb into rspec:main Jul 17, 2022
@pirj
Copy link
Member

pirj commented Jul 17, 2022

Thank you!
My apologies that it took us longer to process this. So long that I had to change "will be deleted in RSpec-Rails 5" to "RSpec-Rails 7" 😄

@klyonrad
Copy link
Contributor Author

@pirj No Problemo. I don't even remember doing this 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate IntegrationGenerator
3 participants