Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rspec::Generators::GeneratorGenerator #1847

Closed
wants to merge 1 commit into from

Conversation

yhirano55
Copy link

My first contribution for rspec-rails.

When we execute bin/rails g generator awesome, rspec-rails does not generate a spec file.
So I've implemented new generator for generator :)

Please let me know if you have advice or questions. Thanks a lot!

@yhirano55 yhirano55 force-pushed the generator_generator branch 3 times, most recently from a0aff79 to 01f4b82 Compare July 19, 2017 04:25
@fables-tales
Copy link
Member

hi @yhirano55 can you explain your use case for this a little more. The code looks fine but I'm just trying to understand what this might be used for in a practical rails app.

@yhirano55
Copy link
Author

yhirano55 commented Aug 26, 2017

@samphippen Thank for the comment. On the test_unit, this boiler template file exist for generator generator. But on RSpec, it doen't have template same as this. Actually, we need to be helped by gem like this to write specs. But first of all, I've tried to make it generate the boiler template for generator generator.

@benoittgt
Copy link
Member

Closing because we now have #2217

@benoittgt benoittgt closed this Jan 22, 2020
@yhirano55 yhirano55 deleted the generator_generator branch January 24, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants