generator for system spec #1933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to make sure these specs only run on rails versions that support system specs. |
|
@andrzejsliwa #2071 looks like a good candidate for including this PR |
|
No this can be independant, it just needs to be gated on Rails version |
joshRpowell
reviewed
Jan 28, 2019
| class SystemGenerator < Base | ||
| class_option :system_specs, :type => :boolean, :default => true, :desc => "Generate system specs" | ||
|
|
||
| def generate_feature_spec |
There was a problem hiding this comment.
should this be generate_system_spec?
joshRpowell
reviewed
Jan 28, 2019
| class_option :system_specs, :type => :boolean, :default => true, :desc => "Generate system specs" | ||
|
|
||
| def generate_feature_spec | ||
| return unless options[:system_specs] |
There was a problem hiding this comment.
@andrzejsliwa perhaps you'll have something more elegant in mind, but inserting something like this is a start:
begin
raise ArgumentError.new('System Tests are available for Rails >= 5.1') if Rails::VERSION::STRING < '5.1'
rescue ArgumentError => e
puts e.message
end
Thanks @JonRowe. Dropped a something to jumpstart the conversation again. |
|
Closed via: #2075 thanks @andrzejsliwa and @joshRpowell 🎉 |
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
Feb 22, 2019
Merged via rspec#2075
benoittgt
added a commit
to benoittgt/rspec-rails
that referenced
this pull request
May 1, 2019
Merged via rspec#2075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspec since 3.7 is supporting the system specs, so would be great to add generator for it.