New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long running 4.0 development branch #2071
Commits on May 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 36c6be5 - Browse repository at this point
Copy the full SHA 36c6be5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 955a99c - Browse repository at this point
Copy the full SHA 955a99cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 424e4ca - Browse repository at this point
Copy the full SHA 424e4caView commit details -
Configuration menu - View commit details
-
Copy full SHA for db401d8 - Browse repository at this point
Copy the full SHA db401d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for faa0856 - Browse repository at this point
Copy the full SHA faa0856View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2074933 - Browse repository at this point
Copy the full SHA 2074933View commit details -
Configuration menu - View commit details
-
Copy full SHA for f847094 - Browse repository at this point
Copy the full SHA f847094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e2179 - Browse repository at this point
Copy the full SHA 11e2179View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c38661 - Browse repository at this point
Copy the full SHA 2c38661View commit details -
Configuration menu - View commit details
-
Copy full SHA for aec8094 - Browse repository at this point
Copy the full SHA aec8094View commit details -
Remove Ruby 2.4.4 from the Rails master matrix (#2073)
Rails 6.0 will require Ruby >= 2.5.0 - see rails/rails#34754.
Configuration menu - View commit details
-
Copy full SHA for ded4c69 - Browse repository at this point
Copy the full SHA ded4c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1296aaa - Browse repository at this point
Copy the full SHA 1296aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b60060 - Browse repository at this point
Copy the full SHA 8b60060View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef511bf - Browse repository at this point
Copy the full SHA ef511bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 484a85e - Browse repository at this point
Copy the full SHA 484a85eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d021c1 - Browse repository at this point
Copy the full SHA 7d021c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 303db70 - Browse repository at this point
Copy the full SHA 303db70View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd104e8 - Browse repository at this point
Copy the full SHA dd104e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a5912 - Browse repository at this point
Copy the full SHA 73a5912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17499fd - Browse repository at this point
Copy the full SHA 17499fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9547ca3 - Browse repository at this point
Copy the full SHA 9547ca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84a4473 - Browse repository at this point
Copy the full SHA 84a4473View commit details -
Configuration menu - View commit details
-
Copy full SHA for da68d7c - Browse repository at this point
Copy the full SHA da68d7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 377ece3 - Browse repository at this point
Copy the full SHA 377ece3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd3106e - Browse repository at this point
Copy the full SHA bd3106eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8daf375 - Browse repository at this point
Copy the full SHA 8daf375View commit details -
Configuration menu - View commit details
-
Copy full SHA for b578a2e - Browse repository at this point
Copy the full SHA b578a2eView commit details -
Fix
ActionView::Template#formats
issue in Rails 6In Rails 6 the `ActionView::Template#formats` method has been deprecated [1] and replaced with `ActionView::Template#format` method. I have attempted to retain support for Rails <= 5.2. [1] https://www.github.com/rails/rails/commit/ca5e23ed4d8
Configuration menu - View commit details
-
Copy full SHA for d59bc0f - Browse repository at this point
Copy the full SHA d59bc0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 511434f - Browse repository at this point
Copy the full SHA 511434fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0731bd1 - Browse repository at this point
Copy the full SHA 0731bd1View commit details -
Avoid deprecation warning for missing local in ActionView::Template
We had some warnings: > DEPRECATION WARNING: ActionView::Template#initialize requires a locals parameter (called from new at /Users/benoit.tigeot/code/rspec-dev/repos/rspec-rails/lib/rspec/rails/view_rendering.rb:54) This was introduced by rails/rails#35411
Configuration menu - View commit details
-
Copy full SHA for 812e3c7 - Browse repository at this point
Copy the full SHA 812e3c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0cb57 - Browse repository at this point
Copy the full SHA 4a0cb57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 506bbac - Browse repository at this point
Copy the full SHA 506bbacView commit details -
Fixes a bunch of tests against rails master
now blocked on rails/rails#36030
Configuration menu - View commit details
-
Copy full SHA for b5032b3 - Browse repository at this point
Copy the full SHA b5032b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18e593 - Browse repository at this point
Copy the full SHA b18e593View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3299ce2 - Browse repository at this point
Copy the full SHA 3299ce2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e743f66 - Browse repository at this point
Copy the full SHA e743f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aed64d - Browse repository at this point
Copy the full SHA 8aed64dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa98520 - Browse repository at this point
Copy the full SHA aa98520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c7955 - Browse repository at this point
Copy the full SHA 46c7955View commit details -
Configuration menu - View commit details
-
Copy full SHA for b83bf19 - Browse repository at this point
Copy the full SHA b83bf19View commit details -
Configuration menu - View commit details
-
Copy full SHA for c24192c - Browse repository at this point
Copy the full SHA c24192cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4335e6f - Browse repository at this point
Copy the full SHA 4335e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e465d - Browse repository at this point
Copy the full SHA c4e465dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0958256 - Browse repository at this point
Copy the full SHA 0958256View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71b98e5 - Browse repository at this point
Copy the full SHA 71b98e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef5f6ea - Browse repository at this point
Copy the full SHA ef5f6eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f925788 - Browse repository at this point
Copy the full SHA f925788View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26b09e6 - Browse repository at this point
Copy the full SHA 26b09e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 522b239 - Browse repository at this point
Copy the full SHA 522b239View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61624fb - Browse repository at this point
Copy the full SHA 61624fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for afa6382 - Browse repository at this point
Copy the full SHA afa6382View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e611e1 - Browse repository at this point
Copy the full SHA 9e611e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c576b40 - Browse repository at this point
Copy the full SHA c576b40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5307677 - Browse repository at this point
Copy the full SHA 5307677View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d19f3 - Browse repository at this point
Copy the full SHA a0d19f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c602283 - Browse repository at this point
Copy the full SHA c602283View commit details -
Configuration menu - View commit details
-
Copy full SHA for b61e12f - Browse repository at this point
Copy the full SHA b61e12fView commit details -
Rename two Rubocop cops in config that break the build
Fix: Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
Configuration menu - View commit details
-
Copy full SHA for a0df04e - Browse repository at this point
Copy the full SHA a0df04eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe8e9d - Browse repository at this point
Copy the full SHA cbe8e9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a2682 - Browse repository at this point
Copy the full SHA b4a2682View commit details
Commits on May 5, 2019
-
allow partial args when using have_enqueued_mail
this provide parity with have_enqueued_job with partial arguments which would be useful especially in negated case where we want to make sure that absolutely no emails are enqueued
Configuration menu - View commit details
-
Copy full SHA for 6d3e66b - Browse repository at this point
Copy the full SHA 6d3e66bView commit details
Commits on May 9, 2019
-
Add ActionMailbox spec helpers and test type (#2119)
* Add ActionMailbox spec helpers and test type Adds the following helpers to example groups with `:type => :mailbox` * process(mail_or_attributes) - send mail directly to the mailbox under test for `process`ing. * receive_inbound_email(mail_or_attributes) - matcher for asserting whether incoming email would route to the mailbox under test. * have_been_delivered - matcher for asserting whether an incoming email object was delivered. * have_bounced - matcher for asserting whether an incoming email object has bounced. * have_failed - matcher for asserting whether an incoming email object has failed. Also adds an ActionMailbox test generator * Add style changes from code review
Configuration menu - View commit details
-
Copy full SHA for 8840963 - Browse repository at this point
Copy the full SHA 8840963View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56cc56c - Browse repository at this point
Copy the full SHA 56cc56cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2d4ab - Browse repository at this point
Copy the full SHA cc2d4abView commit details
Commits on May 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9555946 - Browse repository at this point
Copy the full SHA 9555946View commit details
Commits on May 14, 2019
-
address rubocop offenses: (#2126)
- fix warnings for wrong namespaces - fix safe navigation offense - turn off frozen string literal cop
Configuration menu - View commit details
-
Copy full SHA for f970835 - Browse repository at this point
Copy the full SHA f970835View commit details -
allow partial args when using have_enqueued_mail (#2118)
this provide parity with have_enqueued_job with partial arguments which would be useful especially in negated case where we want to make sure that absolutely no emails are enqueued
Configuration menu - View commit details
-
Copy full SHA for 780b3d2 - Browse repository at this point
Copy the full SHA 780b3d2View commit details -
Simplify the way we explain how to test cookies in controller
The previous documentation was old and was not clear enough to help developers to understand properly how to test cookies inside a controller test. Since then it is much easier to test cookies if you stick to `cookies` and don't use `response.cookies`. You can use response.cookies when you don't change cookies inside your test. ``` def show cookies["user_name"] = nil head 200 end RSpec.describe SignOutsController, type: :request do describe 'GET /signout' do it "clear cookie value" do get "/sign_out" expect(response.cookies["user_name"]).to eq(nil) end end end ``` Use `cookies` to set and expect when you set cookies inside your test ``` def show cookies.delete("user_name") head 200 end RSpec.describe SignOutsController, type: :request do describe 'GET /signout' do it "clear cookie value" do cookies["user_name"] = "Sam" get "/sign_out" expect(cookies["user_name"]).to eq("") end end end ``` This is the prefered way and this is way it is documented like that. Related: - #1993
Configuration menu - View commit details
-
Copy full SHA for 76da141 - Browse repository at this point
Copy the full SHA 76da141View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81d0d60 - Browse repository at this point
Copy the full SHA 81d0d60View commit details
Commits on May 15, 2019
-
add support for recognizing mailer many jobs:
- parameterized mailer when RAILS_VERSION >= 5.1 - unified mailer job when RAILS_VERSION >= 6.0
Configuration menu - View commit details
-
Copy full SHA for 0cbd5b2 - Browse repository at this point
Copy the full SHA 0cbd5b2View commit details -
Add have_broadcasted_to matcher
action-cable-testing migration, pt.1
Configuration menu - View commit details
-
Copy full SHA for 5bf3d13 - Browse repository at this point
Copy the full SHA 5bf3d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba28284 - Browse repository at this point
Copy the full SHA ba28284View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac64a6b - Browse repository at this point
Copy the full SHA ac64a6bView commit details
Commits on May 16, 2019
-
Merge pull request #2125 from ignatiusreza/mailer-job
add support for recognizing mailer many jobs:
Configuration menu - View commit details
-
Copy full SHA for 2a95ded - Browse repository at this point
Copy the full SHA 2a95dedView commit details
Commits on May 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b0c184d - Browse repository at this point
Copy the full SHA b0c184dView commit details
Commits on May 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0b877c5 - Browse repository at this point
Copy the full SHA 0b877c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86db9eb - Browse repository at this point
Copy the full SHA 86db9ebView commit details
Commits on May 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7ff7c3e - Browse repository at this point
Copy the full SHA 7ff7c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d6e5d - Browse repository at this point
Copy the full SHA a6d6e5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d7369 - Browse repository at this point
Copy the full SHA a6d7369View commit details
Commits on May 20, 2019
-
Merge pull request #2131 from rspec/jon_sunday_code_review
Addressing Jon code-review on 4-0-dev
Configuration menu - View commit details
-
Copy full SHA for 1eb171b - Browse repository at this point
Copy the full SHA 1eb171bView commit details
Commits on May 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 81c1f39 - Browse repository at this point
Copy the full SHA 81c1f39View commit details
Commits on May 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 799a1ac - Browse repository at this point
Copy the full SHA 799a1acView commit details
Commits on Jun 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0e3d689 - Browse repository at this point
Copy the full SHA 0e3d689View commit details -
No need to deal with Rails 3 in a filtered feature test
This feature test is filtered on @rails_post_5
Configuration menu - View commit details
-
Copy full SHA for 5780b19 - Browse repository at this point
Copy the full SHA 5780b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666751f - Browse repository at this point
Copy the full SHA 666751fView commit details
Commits on Jun 8, 2019
-
Merge pull request #2134 from 00dav00/routing_specs_for_controller_ge…
…nerator Create controller generator for routing specs
Configuration menu - View commit details
-
Copy full SHA for 9c6d8f3 - Browse repository at this point
Copy the full SHA 9c6d8f3View commit details
Commits on Jul 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 65ec96c - Browse repository at this point
Copy the full SHA 65ec96cView commit details
Commits on Aug 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f01e4ff - Browse repository at this point
Copy the full SHA f01e4ffView commit details -
Merge pull request #2158 from rspec/fix-build
Prevent uninstalling bundler on newer rails
Configuration menu - View commit details
-
Copy full SHA for 395f34b - Browse repository at this point
Copy the full SHA 395f34bView commit details
Commits on Aug 27, 2019
-
Merge pull request #2164 from rspec/fix-teardown-hooks
Blowaway before hooks as well as after hooks to preserve order
Configuration menu - View commit details
-
Copy full SHA for b118fc6 - Browse repository at this point
Copy the full SHA b118fc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b37f0 - Browse repository at this point
Copy the full SHA 73b37f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b667636 - Browse repository at this point
Copy the full SHA b667636View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aa8f80 - Browse repository at this point
Copy the full SHA 4aa8f80View commit details -
Prevent webdrivers from using `&.` method on unsupported ruby.
Configuration menu - View commit details
-
Copy full SHA for 7ddd679 - Browse repository at this point
Copy the full SHA 7ddd679View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7170faf - Browse repository at this point
Copy the full SHA 7170fafView commit details -
Specify trusty for TravisCI build
RVM doesn't provide old Ruby binaries for newer Ubuntu distributions. Until it's fixed, we need to use old Ubuntu distributions in CI.
Configuration menu - View commit details
-
Copy full SHA for b2ecc1e - Browse repository at this point
Copy the full SHA b2ecc1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d01616 - Browse repository at this point
Copy the full SHA 3d01616View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d48f4a - Browse repository at this point
Copy the full SHA 5d48f4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56dc8d4 - Browse repository at this point
Copy the full SHA 56dc8d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a26fbb6 - Browse repository at this point
Copy the full SHA a26fbb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce2e9e2 - Browse repository at this point
Copy the full SHA ce2e9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e5d28a - Browse repository at this point
Copy the full SHA 7e5d28aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ddf9e - Browse repository at this point
Copy the full SHA 34ddf9eView commit details -
Add selenium to avoid loading issue in 'action_dispatch/system_test_c…
…ase' On Rails 6 we add error in test suite like: ``` LoadError: cannot load such file -- selenium/webdriver System test integration requires Rails >= 5.1 and has a hard dependency on a webserver and `capybara`, please add capybara to your Gemfile and configure a webserver (e.g. `Capybara.server = :webrick`) before attempting to use system specs. ``` Thoses errors come from `lib/rspec/rails/example/system_example_group.rb#L51`: ``` 2.6.3 :002 > require 'action_dispatch/system_test_case' Traceback (most recent call last): 16: from /Users/bti/code/rspec-dev/repos/rspec-rails/spec/rspec/rails/example/system_example_group_spec.rb:11:in `block (4 levels) in <module:Rails>' 15: from /Users/bti/code/rspec-dev/repos/rspec-rails/spec/rspec/rails/example/system_example_group_spec.rb:11:in `include' 14: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/concern.rb:122:in `append_features' 13: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/concern.rb:122:in `class_eval' 12: from /Users/bti/code/rspec-dev/repos/rspec-rails/lib/rspec/rails/example/system_example_group.rb:50:in `block in <module:SystemExampleGroup>' 11: from <internal:prelude>:145:in `irb' 10: from (irb):2:in `block in <module:SystemExampleGroup>' 9: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require' 8: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency' 7: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `block in require' 6: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require' 5: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/actionpack-6.0.0/lib/action_dispatch/system_test_case.rb:7:in `<top (required)>' 4: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require' 3: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency' 2: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `block in require' 1: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require' LoadError (cannot load such file -- selenium/webdriver) ``` This is probably related to: > rails/rails#36592 We need to load selenium-driver if we are in Rails 6
Configuration menu - View commit details
-
Copy full SHA for 37875c2 - Browse repository at this point
Copy the full SHA 37875c2View commit details -
Avoid too much failures on Rubocop cop changes
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)
Configuration menu - View commit details
-
Copy full SHA for fbc4aa9 - Browse repository at this point
Copy the full SHA fbc4aa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753f5bc - Browse repository at this point
Copy the full SHA 753f5bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb7d52 - Browse repository at this point
Copy the full SHA 2bb7d52View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe90da4 - Browse repository at this point
Copy the full SHA fe90da4View commit details
Commits on Aug 28, 2019
-
Merge pull request #2160 from benoittgt/rebase_4-0-dev
Rebase master to 4-0-dev and fix build
Configuration menu - View commit details
-
Copy full SHA for 1b47a5e - Browse repository at this point
Copy the full SHA 1b47a5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16cd02e - Browse repository at this point
Copy the full SHA 16cd02eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39cbd9e - Browse repository at this point
Copy the full SHA 39cbd9eView commit details
Commits on Sep 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for afd6ea2 - Browse repository at this point
Copy the full SHA afd6ea2View commit details
Commits on Sep 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 093a16f - Browse repository at this point
Copy the full SHA 093a16fView commit details -
Add log to better understand gem bundler uninstallation on CI
Sometimes we can have inconsistent behavior with the CI when we uninstall Bundler gem. This can lead to one version that is not properly uninstalled. To have a better understanding of the situation, this PR ad a log point and switch back to old behavior of uninstalling as much as possible bundler version before installing bundler 1.17.3 in case of Rails below 5. Old behavior commit : 753f5bc Related: #2071
Configuration menu - View commit details
-
Copy full SHA for d401812 - Browse repository at this point
Copy the full SHA d401812View commit details
Commits on Sep 5, 2019
-
Merge pull request #2170 from rspec/4-0-dev-log-ci-uninstall
Add log when downgrading bundler
Configuration menu - View commit details
-
Copy full SHA for 1d56c29 - Browse repository at this point
Copy the full SHA 1d56c29View commit details
Commits on Sep 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e8bc2d9 - Browse repository at this point
Copy the full SHA e8bc2d9View commit details -
Merge pull request #2157 from alpaca-tc/have_enqueued_job_time
have_enqueued_job supports time object
Configuration menu - View commit details
-
Copy full SHA for 0fe7631 - Browse repository at this point
Copy the full SHA 0fe7631View commit details -
Configuration menu - View commit details
-
Copy full SHA for c11a1b6 - Browse repository at this point
Copy the full SHA c11a1b6View commit details
Commits on Sep 23, 2019
-
Designate existing issue template as bug report template and move to a hidden directory (.github/ISSUE_TEMPLATE/) to enable multiple issue templates. See https://help.github.com/en/articles/creating-issue-templates-for-your-repository
Configuration menu - View commit details
-
Copy full SHA for aa4f0cb - Browse repository at this point
Copy the full SHA aa4f0cbView commit details -
A generic feature request template generated by github issue template builder.
Configuration menu - View commit details
-
Copy full SHA for 3a893a8 - Browse repository at this point
Copy the full SHA 3a893a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5f27cd - Browse repository at this point
Copy the full SHA f5f27cdView commit details -
Provide instructions in issue templates
Indicate the preferred process of requesting users to first discuss feature requests in the project google group.
Configuration menu - View commit details
-
Copy full SHA for 7d42e08 - Browse repository at this point
Copy the full SHA 7d42e08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f5dd6d - Browse repository at this point
Copy the full SHA 7f5dd6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b56320 - Browse repository at this point
Copy the full SHA 9b56320View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f5ef5 - Browse repository at this point
Copy the full SHA 92f5ef5View commit details -
Merge pull request #2174 from rspec/fix-build-4-0-dev
Pin minitest on older Rubies
Configuration menu - View commit details
-
Copy full SHA for 4a933fd - Browse repository at this point
Copy the full SHA 4a933fdView commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dadd9ff - Browse repository at this point
Copy the full SHA dadd9ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6becab - Browse repository at this point
Copy the full SHA e6becabView commit details -
Merge pull request #2148 from olleolleolle/4-0-java-opts
CI: Add --add-opens in order to support JDK11
Configuration menu - View commit details
-
Copy full SHA for 9e48616 - Browse repository at this point
Copy the full SHA 9e48616View commit details
Commits on Oct 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f9e5f1b - Browse repository at this point
Copy the full SHA f9e5f1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca158fc - Browse repository at this point
Copy the full SHA ca158fcView commit details
Commits on Oct 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1758815 - Browse repository at this point
Copy the full SHA 1758815View commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6728e9d - Browse repository at this point
Copy the full SHA 6728e9dView commit details