Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long running 4.0 development branch #2071

Merged
merged 135 commits into from Oct 18, 2019
Merged

Long running 4.0 development branch #2071

merged 135 commits into from Oct 18, 2019

Commits on May 1, 2019

  1. Setup gemspec for 4.0

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    36c6be5 View commit details
    Browse the repository at this point in the history
  2. Gets rubocop working on modern rubocops and rubies.

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    955a99c View commit details
    Browse the repository at this point in the history
  3. Remove now unsupported rubies.

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    424e4ca View commit details
    Browse the repository at this point in the history
  4. Fix cops

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    db401d8 View commit details
    Browse the repository at this point in the history
  5. Rails versions

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    faa0856 View commit details
    Browse the repository at this point in the history
  6. cleanup gemfile

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    2074933 View commit details
    Browse the repository at this point in the history
  7. Further version checking fixes

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    f847094 View commit details
    Browse the repository at this point in the history
  8. Remove old rubies

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    11e2179 View commit details
    Browse the repository at this point in the history
  9. Track 2.6

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    2c38661 View commit details
    Browse the repository at this point in the history
  10. 2.6.0 and 4.2 dont get along

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    aec8094 View commit details
    Browse the repository at this point in the history
  11. Remove Ruby 2.4.4 from the Rails master matrix (#2073)

    Rails 6.0 will require Ruby >= 2.5.0 - see rails/rails#34754.
    pixeltrix authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ded4c69 View commit details
    Browse the repository at this point in the history
  12. The #hash method was renamed to #data. (#2076)

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    1296aaa View commit details
    Browse the repository at this point in the history
  13. Gets rubocop working on modern rubocops and rubies.

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    8b60060 View commit details
    Browse the repository at this point in the history
  14. Remove useless empty lines

    benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ef511bf View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    484a85e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7d021c1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    303db70 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    dd104e8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    73a5912 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    17499fd View commit details
    Browse the repository at this point in the history
  21. #hash was removed

    ahorek authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    9547ca3 View commit details
    Browse the repository at this point in the history
  22. AV::Base use empty

    ahorek authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    84a4473 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    da68d7c View commit details
    Browse the repository at this point in the history
  24. expand arguments

    ahorek authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    377ece3 View commit details
    Browse the repository at this point in the history
  25. fix arity

    ahorek authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    bd3106e View commit details
    Browse the repository at this point in the history
  26. jbuilder

    ahorek authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    8daf375 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    b578a2e View commit details
    Browse the repository at this point in the history
  28. Fix ActionView::Template#formats issue in Rails 6

    In Rails 6 the `ActionView::Template#formats` method has been deprecated
    [1] and replaced with `ActionView::Template#format` method.
    
    I have attempted to retain support for Rails <= 5.2.
    
    [1] https://www.github.com/rails/rails/commit/ca5e23ed4d8
    sebjacobs authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    d59bc0f View commit details
    Browse the repository at this point in the history
  29. Changelog for Rails 6 updates.

    JonRowe authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    511434f View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    0731bd1 View commit details
    Browse the repository at this point in the history
  31. Avoid deprecation warning for missing local in ActionView::Template

    We had some warnings:
    > DEPRECATION WARNING: ActionView::Template#initialize requires a locals parameter (called from new at /Users/benoit.tigeot/code/rspec-dev/repos/rspec-rails/lib/rspec/rails/view_rendering.rb:54)
    
    This was introduced by rails/rails#35411
    benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    812e3c7 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    4a0cb57 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    506bbac View commit details
    Browse the repository at this point in the history
  34. Fixes a bunch of tests against rails master

    now blocked on rails/rails#36030
    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b5032b3 View commit details
    Browse the repository at this point in the history
  35. Fix active storage load in no activerecord app

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b18e593 View commit details
    Browse the repository at this point in the history
  36. Fix rails version handling for master builds

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    3299ce2 View commit details
    Browse the repository at this point in the history
  37. Fix broken empty rendering cuke.

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    e743f66 View commit details
    Browse the repository at this point in the history
  38. Fix various subbing in builds

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    8aed64d View commit details
    Browse the repository at this point in the history
  39. Fix splitting

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    aa98520 View commit details
    Browse the repository at this point in the history
  40. Fix minor and major initialization for master

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    46c7955 View commit details
    Browse the repository at this point in the history
  41. Really fix for master

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b83bf19 View commit details
    Browse the repository at this point in the history
  42. YOLO jruby

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    c24192c View commit details
    Browse the repository at this point in the history
  43. Fix jruby

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    4335e6f View commit details
    Browse the repository at this point in the history
  44. r u kidding me

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    c4e465d View commit details
    Browse the repository at this point in the history
  45. Jruby fixes

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    0958256 View commit details
    Browse the repository at this point in the history
  46. more jruby fixces

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    71b98e5 View commit details
    Browse the repository at this point in the history
  47. Jruby fixes

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ef5f6ea View commit details
    Browse the repository at this point in the history
  48. smoke

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    f925788 View commit details
    Browse the repository at this point in the history
  49. Stabalize rails targetting.

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    26b09e6 View commit details
    Browse the repository at this point in the history
  50. Bump mime types to ~> 3

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    522b239 View commit details
    Browse the repository at this point in the history
  51. Add Changelog and explicit jruby support for 5.2

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    61624fb View commit details
    Browse the repository at this point in the history
  52. Skip failing spec on jruby

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    afa6382 View commit details
    Browse the repository at this point in the history
  53. Fix jruby pins for the JDBC dependency

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    9e611e1 View commit details
    Browse the repository at this point in the history
  54. Fix travis.yml jruby configuration

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    c576b40 View commit details
    Browse the repository at this point in the history
  55. Fix capybara pins for older rubies

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    5307677 View commit details
    Browse the repository at this point in the history
  56. Release beta1

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    a0d19f3 View commit details
    Browse the repository at this point in the history
  57. Fix gemspec generation of deps

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    c602283 View commit details
    Browse the repository at this point in the history
  58. Release 4.0.0.beta2

    Sam Phippen authored and benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b61e12f View commit details
    Browse the repository at this point in the history
  59. Rename two Rubocop cops in config that break the build

    Fix:
    Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`.
    (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
    The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`.
    (obsolete configuration found in .rubocop_rspec_base.yml, please update it)
    benoittgt committed May 1, 2019
    Configuration menu
    Copy the full SHA
    a0df04e View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    cbe8e9d View commit details
    Browse the repository at this point in the history
  61. Improve path parsing in _default_render_options (#2115)

    jhawthorn authored and Sam Phippen committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b4a2682 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2019

  1. allow partial args when using have_enqueued_mail

    this provide parity with have_enqueued_job with partial arguments
    which would be useful especially in negated case where
    we want to make sure that absolutely no emails are enqueued
    ignatiusreza committed May 5, 2019
    Configuration menu
    Copy the full SHA
    6d3e66b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. Add ActionMailbox spec helpers and test type (#2119)

    * Add ActionMailbox spec helpers and test type
    
    Adds the following helpers to example groups with `:type => :mailbox`
    
    * process(mail_or_attributes) - send mail directly to the mailbox under test for
      `process`ing.
    * receive_inbound_email(mail_or_attributes) - matcher for asserting whether incoming
      email would route to the mailbox under test.
    * have_been_delivered - matcher for asserting whether an incoming email object was delivered.
    * have_bounced - matcher for asserting whether an incoming email object has bounced.
    * have_failed - matcher for asserting whether an incoming email object has failed.
    
    Also adds an ActionMailbox test generator
    
    * Add style changes from code review
    jamesdabbs-procore authored and Sam Phippen committed May 9, 2019
    Configuration menu
    Copy the full SHA
    8840963 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56cc56c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cc2d4ab View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Fix ActionMailbox feature checks

    jamesdabbs authored and benoittgt committed May 11, 2019
    Configuration menu
    Copy the full SHA
    9555946 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. address rubocop offenses: (#2126)

    - fix warnings for wrong namespaces
    - fix safe navigation offense
    - turn off frozen string literal cop
    ignatiusreza authored and JonRowe committed May 14, 2019
    Configuration menu
    Copy the full SHA
    f970835 View commit details
    Browse the repository at this point in the history
  2. allow partial args when using have_enqueued_mail (#2118)

    this provide parity with have_enqueued_job with partial arguments
    which would be useful especially in negated case where
    we want to make sure that absolutely no emails are enqueued
    JonRowe committed May 14, 2019
    Configuration menu
    Copy the full SHA
    780b3d2 View commit details
    Browse the repository at this point in the history
  3. Simplify the way we explain how to test cookies in controller

    The previous documentation was old and was not clear enough to help
    developers to understand properly how to test cookies inside a
    controller test. Since then it is much easier to test cookies if you
    stick to `cookies` and don't use `response.cookies`.
    
    You can use response.cookies when you don't change cookies inside your
    test.
    
    ```
    def show
      cookies["user_name"] = nil
      head 200
    end
    
    RSpec.describe SignOutsController, type: :request do
      describe 'GET /signout' do
        it "clear cookie value" do
          get "/sign_out"
    
          expect(response.cookies["user_name"]).to eq(nil)
        end
      end
    end
    ```
    
    Use `cookies` to set and expect when you set cookies inside your test
    
    ```
    def show
      cookies.delete("user_name")
      head 200
    end
    
    RSpec.describe SignOutsController, type: :request do
      describe 'GET /signout' do
        it "clear cookie value" do
          cookies["user_name"] = "Sam"
    
          get "/sign_out"
    
          expect(cookies["user_name"]).to eq("")
        end
      end
    end
    ```
    
    This is the prefered way and this is way it is documented like that.
    
    Related:
    - #1993
    benoittgt committed May 14, 2019
    Configuration menu
    Copy the full SHA
    76da141 View commit details
    Browse the repository at this point in the history
  4. Correct grammatical issues

    benoittgt committed May 14, 2019
    Configuration menu
    Copy the full SHA
    81d0d60 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. add support for recognizing mailer many jobs:

    - parameterized mailer when RAILS_VERSION >= 5.1
    - unified mailer job when RAILS_VERSION >= 6.0
    ignatiusreza committed May 15, 2019
    Configuration menu
    Copy the full SHA
    0cbd5b2 View commit details
    Browse the repository at this point in the history
  2. Add have_broadcasted_to matcher

    action-cable-testing migration, pt.1
    palkan authored and benoittgt committed May 15, 2019
    Configuration menu
    Copy the full SHA
    5bf3d13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba28284 View commit details
    Browse the repository at this point in the history
  4. Add channel spec generator

    palkan authored and benoittgt committed May 15, 2019
    Configuration menu
    Copy the full SHA
    ac64a6b View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Merge pull request #2125 from ignatiusreza/mailer-job

    add support for recognizing mailer many jobs:
    JonRowe committed May 16, 2019
    Configuration menu
    Copy the full SHA
    2a95ded View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Changelog for #2125

    JonRowe committed May 17, 2019
    Configuration menu
    Copy the full SHA
    b0c184d View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Changelog for #2119, #2113, #2125

    benoittgt committed May 18, 2019
    Configuration menu
    Copy the full SHA
    0b877c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86db9eb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2019

  1. add missing require to have_enqueued_mail (#2117)

    ignatiusreza authored and Sam Phippen committed May 19, 2019
    Configuration menu
    Copy the full SHA
    7ff7c3e View commit details
    Browse the repository at this point in the history
  2. Reuse feature check methods

    benoittgt committed May 19, 2019
    Configuration menu
    Copy the full SHA
    a6d6e5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a6d7369 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. Merge pull request #2131 from rspec/jon_sunday_code_review

    Addressing Jon code-review on 4-0-dev
    JonRowe committed May 20, 2019
    Configuration menu
    Copy the full SHA
    1eb171b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. use jbuilder from rubygems

    ahorek committed May 23, 2019
    Configuration menu
    Copy the full SHA
    81c1f39 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Merge pull request #2133 from ahorek/jb

    use jbuilder from rubygems
    JonRowe committed May 24, 2019
    Configuration menu
    Copy the full SHA
    799a1ac View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Configuration menu
    Copy the full SHA
    0e3d689 View commit details
    Browse the repository at this point in the history
  2. No need to deal with Rails 3 in a filtered feature test

    This feature test is filtered on @rails_post_5
    benoittgt committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    5780b19 View commit details
    Browse the repository at this point in the history
  3. Create controller generator for routing specs (#1160)

    David Revelo authored and 00dav00 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    666751f View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2019

  1. Merge pull request #2134 from 00dav00/routing_specs_for_controller_ge…

    …nerator
    
    Create controller generator for routing specs
    JonRowe committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    9c6d8f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. CI: --add-opens to JRuby

    olleolleolle committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    65ec96c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Configuration menu
    Copy the full SHA
    f01e4ff View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2158 from rspec/fix-build

    Prevent uninstalling bundler on newer rails
    JonRowe committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    395f34b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Merge pull request #2164 from rspec/fix-teardown-hooks

    Blowaway before hooks as well as after hooks to preserve order
    JonRowe committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    b118fc6 View commit details
    Browse the repository at this point in the history
  2. RFC: versioning strategy (#1967)

    Sam Phippen authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    73b37f0 View commit details
    Browse the repository at this point in the history
  3. Whitespace cleanup

    [skip ci]
    JonRowe authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    b667636 View commit details
    Browse the repository at this point in the history
  4. Change log for #2134

    JonRowe authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    4aa8f80 View commit details
    Browse the repository at this point in the history
  5. Pin webdrivers on older ruby.

    Prevent webdrivers from using `&.` method on unsupported ruby.
    JonRowe authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7ddd679 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7170faf View commit details
    Browse the repository at this point in the history
  7. Specify trusty for TravisCI build

    RVM doesn't provide old Ruby binaries for newer Ubuntu distributions.
    Until it's fixed, we need to use old Ubuntu distributions in CI.
    okuramasafumi authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    b2ecc1e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3d01616 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5d48f4a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    56dc8d4 View commit details
    Browse the repository at this point in the history
  11. Fix capybara pins for older rubies

    Sam Phippen authored and benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    a26fbb6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ce2e9e2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7e5d28a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    34ddf9e View commit details
    Browse the repository at this point in the history
  15. Add selenium to avoid loading issue in 'action_dispatch/system_test_c…

    …ase'
    
    On Rails 6 we add error in test suite like:
    ```
    LoadError: cannot load such file -- selenium/webdriver System test integration requires Rails >= 5.1 and has a hard dependency on a webserver and `capybara`, please add capybara to your Gemfile and configure a webserver (e.g. `Capybara.server = :webrick`) before attempting to use system specs.
    ```
    
    Thoses errors come from
    `lib/rspec/rails/example/system_example_group.rb#L51`:
    
    ```
    2.6.3 :002 > require 'action_dispatch/system_test_case'
    Traceback (most recent call last):
           16: from /Users/bti/code/rspec-dev/repos/rspec-rails/spec/rspec/rails/example/system_example_group_spec.rb:11:in `block (4 levels) in <module:Rails>'
           15: from /Users/bti/code/rspec-dev/repos/rspec-rails/spec/rspec/rails/example/system_example_group_spec.rb:11:in `include'
           14: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/concern.rb:122:in `append_features'
           13: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/concern.rb:122:in `class_eval'
           12: from /Users/bti/code/rspec-dev/repos/rspec-rails/lib/rspec/rails/example/system_example_group.rb:50:in `block in <module:SystemExampleGroup>'
           11: from <internal:prelude>:145:in `irb'
           10: from (irb):2:in `block in <module:SystemExampleGroup>'
            9: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require'
            8: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency'
            7: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `block in require'
            6: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require'
            5: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/actionpack-6.0.0/lib/action_dispatch/system_test_case.rb:7:in `<top (required)>'
            4: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require'
            3: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:291:in `load_dependency'
            2: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `block in require'
            1: from /Users/bti/.rvm/gems/ruby-2.6.3/gems/activesupport-6.0.0/lib/active_support/dependencies.rb:325:in `require'
    LoadError (cannot load such file -- selenium/webdriver)
    ```
    
    This is probably related to:
    > rails/rails#36592
    
    We need to load selenium-driver if we are in Rails 6
    benoittgt committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    37875c2 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    fbc4aa9 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    753f5bc View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2bb7d52 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    fe90da4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Merge pull request #2160 from benoittgt/rebase_4-0-dev

    Rebase master to 4-0-dev and fix build
    JonRowe committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    1b47a5e View commit details
    Browse the repository at this point in the history
  2. Change log for #2164

    JonRowe committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    16cd02e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39cbd9e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Configuration menu
    Copy the full SHA
    afd6ea2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Configuration menu
    Copy the full SHA
    093a16f View commit details
    Browse the repository at this point in the history
  2. Add log to better understand gem bundler uninstallation on CI

    Sometimes we can have inconsistent behavior with the CI when we uninstall Bundler gem. This can lead to one version that is not properly uninstalled. To have a better understanding of the situation, this PR ad a log point and switch back to old behavior of uninstalling as much as possible bundler version before installing bundler 1.17.3 in case of Rails below 5.
    
    Old behavior commit : 753f5bc
    Related: #2071
    benoittgt committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    d401812 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Merge pull request #2170 from rspec/4-0-dev-log-ci-uninstall

    Add log when downgrading bundler
    JonRowe committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1d56c29 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Configuration menu
    Copy the full SHA
    e8bc2d9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2157 from alpaca-tc/have_enqueued_job_time

    have_enqueued_job supports time object
    JonRowe committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    0fe7631 View commit details
    Browse the repository at this point in the history
  3. Update Changelog.md

    JonRowe committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    c11a1b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Move issue template

    Designate existing issue template as bug report template
    and move to a hidden directory (.github/ISSUE_TEMPLATE/)
    to enable multiple issue templates.
    
    See https://help.github.com/en/articles/creating-issue-templates-for-your-repository
    Kieran O'Grady authored and JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    aa4f0cb View commit details
    Browse the repository at this point in the history
  2. Add feature request template

    A generic feature request template generated by github
    issue template builder.
    Kieran O'Grady authored and JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    3a893a8 View commit details
    Browse the repository at this point in the history
  3. Link to issue templates in CONTRIBUTING.md

    Kieran O'Grady authored and JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    f5f27cd View commit details
    Browse the repository at this point in the history
  4. Provide instructions in issue templates

    Indicate the preferred process of requesting users to first
    discuss feature requests in the project google group.
    Kieran O'Grady authored and JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    7d42e08 View commit details
    Browse the repository at this point in the history
  5. Pin minitest on older Rubies

    JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    7f5dd6d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9b56320 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    92f5ef5 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2174 from rspec/fix-build-4-0-dev

    Pin minitest on older Rubies
    JonRowe committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    4a933fd View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Configuration menu
    Copy the full SHA
    dadd9ff View commit details
    Browse the repository at this point in the history
  2. CI: Try jdk: oraclejdk11

    olleolleolle committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    e6becab View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2148 from olleolleolle/4-0-java-opts

    CI: Add --add-opens in order to support JDK11
    JonRowe committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9e48616 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Correct ws

    JonRowe committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    f9e5f1b View commit details
    Browse the repository at this point in the history
  2. Add missing RSpec references

    JonRowe committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    ca158fc View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Configuration menu
    Copy the full SHA
    1758815 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Add missing changelog entries

    JonRowe committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    6728e9d View commit details
    Browse the repository at this point in the history