added generator spec generator and spec tests #2085
Conversation
|
attempts to resolve #2084 |
|
Hello, I'm not entirely sure why it failed in Ruby 1.9.2 after looking at the job logs. I'd love to fix this if you have any thoughts on what could have caused it! |
| @@ -0,0 +1,26 @@ | |||
| require 'generators/rspec' | |||
|
|
|||
| if ::Rails::VERSION::STRING >= '5.1' | |||
There was a problem hiding this comment.
Why only Rails 5.1 and above? All Rails versions have generators?
There was a problem hiding this comment.
Thanks for pointing this out! I was looking at the system generator to help with creating this generator and forgot to take that out. But it is now removed in the new commit.
| RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:generator) %> do | ||
| before do | ||
| driven_by(:rack_test) | ||
| end |
There was a problem hiding this comment.
Generators don't have system test functionality, this should be able to go :)
| @@ -0,0 +1,40 @@ | |||
| # Generators are not automatically loaded by rails | |||
| if ::Rails::VERSION::STRING >= '5.1' | |||
There was a problem hiding this comment.
If the other rails version if is removed so should this.
|
I reran the failing job for 1.9.2 |
|
Hello, @JonRowe I appreciate the review/feedback! I have made the changes in the new commit. Let me know if there is anything else that needs to be adjusted or changed! :) @benoittgt thank you for re-running the failing job, seems like that resolved it! |
|
It seems you have indentation issue https://travis-ci.org/rspec/rspec-rails/jobs/499390139 |
|
My mistake, I fixed indention in most recent commit! |
|
No worries! I've got that changed now, before I commit do we want the |
|
Yes it needs to be with its cohorts |
|
I made those adjustments to the names, let me know if there is anything else! |
|
I'm seeing a bunch of errors after the most recent commit. I will work on resolving them |
| require 'generators/rspec/generators/generator_generator' | ||
| require 'support/generators' | ||
|
|
||
| RSpec.describe Rspec::Generators::GeneratorsGenerator, :type => :generator do |
There was a problem hiding this comment.
Can you fix the indentation here? Its not quite right (all of this file needs 2 spaces removing)
| module Generators | ||
| # @private | ||
| class GeneratorsGenerator < Base | ||
| class_option :generator_specs, :type => :boolean, :default => true, :desc => "Generate generator specs" |
There was a problem hiding this comment.
I think :default should be false here
|
|
||
| describe "generator specs" do | ||
| subject(:generator_spec) { file("spec/generator/posts_generator_spec.rb") } | ||
| describe "are generated independently from the command line" do |
There was a problem hiding this comment.
s/describe/context and s/are generated independently/can be generated
| before do | ||
| run_generator %w(posts) | ||
| end | ||
| describe "the spec" do |
There was a problem hiding this comment.
You can collapse this into the docs strings below:
it "creates the spec file"
it "includes the rails helper in the spec file"
it "includes the generator type in the metadata"
| end | ||
| end | ||
|
|
||
| describe "are not generated" do |
There was a problem hiding this comment.
s/describe/context s/are not generated/are skipped by default
| subject(:generator_spec) { file("spec/generator/posts_generator_spec.rb") } | ||
| describe "are generated independently from the command line" do | ||
| before do | ||
| run_generator %w(posts) |
|
|
||
| describe "are not generated" do | ||
| before do | ||
| run_generator %w(posts --no-generator-specs) |
There was a problem hiding this comment.
Can remove the --no-generator-specs
|
Hey @JonRowe, I made those changes. Let me know how it looks! |
Added generator spec generator
No description provided.