Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EmptyTemplateHandler compatible with Rails 6 #2095

Closed
wants to merge 1 commit into from
Closed

Make EmptyTemplateHandler compatible with Rails 6 #2095

wants to merge 1 commit into from

Conversation

palkan
Copy link
Contributor

@palkan palkan commented Feb 28, 2019

Rails version: 6.0.0.beta2

RSpec-Rails fails with:

ActionView::Template::Error:
       wrong number of arguments (given 2, expected 1)

It turned out that templates API has changed in Rails 6: rails/rails#35119.

@JonRowe
Copy link
Member

JonRowe commented Mar 1, 2019

Thanks for this, but we've already had this reported and fixed. Closing as duplicate of #2086 #2089 and #2091, already merged into 4-0-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants