add missing require to have_enqueued_mail

[ignatiusreza]

Hiya, I'm having issue when trying out #2047 in the beta release.. the error raised was You must pass an argument rather than a block to 'expect' to use the provided matcher (have enqueued mail ReservationMailer, :complete), or the matcher must implement 'supports_block_expectations?'.

which seems to be caused by the matcher not being required.. hence, this PR fix it by adding the missing require call..

[benoittgt]

Thanks LGTM.

[fables-tales]

Hi there @ignatiusreza I ran our build against this PR and got the following failing features:

cucumber features/matchers/have_enqueued_mail_matcher.feature:9 # Scenario: Checking mailer class and method name
cucumber features/matchers/have_enqueued_mail_matcher.feature:26 # Scenario: Checking mailer enqueued time
cucumber features/matchers/have_enqueued_mail_matcher.feature:43 # Scenario: Checking mailer enqueued with no wait
cucumber features/matchers/have_enqueued_mail_matcher.feature:60 # Scenario: Using alias method

do I need to do something to get these green ?

[ignatiusreza]

hi @samphippen, I rebased the branch to run this PR against CI, and just noticed that it's failing when RAILS_VERSION is not on 5.* family.. sorry about that, i'll investigate further..

[ignatiusreza]

I dig down a bit deeper, and found that the default mailer delivery job changed in rails 6 (see: rails/rails#34591 & rails/rails#34692).. in our test environment, rspec passes since it's still using ActionMailer::DeliveryJob, while cucumber failed since it is run against freshly generated rails 6 application and uses ActionMailer::MailDeliveryJob..

since this PR is about adding missing require line, should I open a different PR to update the job matching logic? or should I add it here? incidentally, I also opened a different PR for adding support for parameterized mailer in #2121.. so maybe it's best to consolidate the effort in that PR? wdyt?

[JonRowe]

I'm happy with this if you are @samphippen

[fables-tales]

@ignatiusreza can you look at the build failures here and let us know what's up or if you need some help?

[ignatiusreza]

@samphippen i found the issue and opened #2125 to address it.. i'll rebase this branch after #2125 is merged, and ci should pass..

[ignatiusreza]

All green now!

[fables-tales]

LGTM

[JonRowe]

This has also been released in 3.9.1 now.