Fix system_test_example teardown #2141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original `after_teardown` must be called after the original `before_teardown` (which is added to `after` hooks by RSpec::Rails::MinitestLifecycleAdapter). Fixes taking failures screenshot functionality (changed in rails/rails@ef12ccf). (cherry picked from commit fa17edb)
|
@JonRowe Just checked |
|
Can you check |
|
|
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Failure screenshots stopped working in Rails 6.0 RC1: at the time of taking a screenshot the browser is reset to
about:page (in case of Chrome), resulting in a blank page screenshots.The solution
Original
after_teardownmust be called after the originalbefore_teardown(which is added toafterhooks by RSpec::Rails::MinitestLifecycleAdapter).The behavior in Rails changed with this commit: rails/rails@ef12ccf.
Not sure, how to add a test for this change (except from "checked on my project—works like a charm"; it's passing, btw).