Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generator spec generator #2217

Merged
merged 8 commits into from Jan 22, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 33 additions & 0 deletions features/generator_specs/generator_specs.feature
@@ -0,0 +1,33 @@
Feature: Generator spec

RSpec spec are normally generated alongside other application components.
benoittgt marked this conversation as resolved.
Show resolved Hide resolved
For instance, `rails generate model` will also generate an RSpec spec file
for the model but you can also use your own generator. See
benoittgt marked this conversation as resolved.
Show resolved Hide resolved
[customizing your workflow](https://guides.rubyonrails.org/generators.html#customizing-your-workflow)
benoittgt marked this conversation as resolved.
Show resolved Hide resolved

@remove-generator-files
Scenario: Use custom generator without '--generator-specs' arg
When I run `bundle exec rails generate generator my_generator`
Then the features should pass
Then the output should contain:
"""
create lib/generators/my_generator
create lib/generators/my_generator/my_generator_generator.rb
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
"""

@remove-generator-files
Scenario: Use custom generator with '--generator-specs' arg
When I run `bundle exec rails generate generator my_generator --generator-specs`
Then the features should pass
Then the output should contain:
"""
create lib/generators/my_generator
create lib/generators/my_generator/my_generator_generator.rb
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
create spec/generator/my_generators_generator_spec.rb
"""
11 changes: 11 additions & 0 deletions features/support/hooks.rb
@@ -0,0 +1,11 @@
Before('@remove-generator-files') do
command = <<-COMMAND
rm -f \
tmp/example_app/lib/generators/my_generator \
tmp/example_app/lib/generators/my_generator/my_generator_generator.rb \
tmp/example_app/lib/generators/my_generator/USAGE \
tmp/example_app/lib/generators/my_generator/templates \
tmp/example_app/spec/generator/my_generator_spec.rb
COMMAND
system(command)
end
benoittgt marked this conversation as resolved.
Show resolved Hide resolved
Expand Up @@ -3,7 +3,7 @@
module Rspec
module Generators
# @private
class GeneratorsGenerator < Base
class GeneratorGenerator < Base
class_option :generator_specs, type: :boolean, default: false, desc: "Generate generator specs"

def generate_generator_spec
Expand Down
@@ -1,7 +1,7 @@
require 'generators/rspec/generators/generator_generator'
require 'generators/rspec/generator/generator_generator'
require 'support/generators'

RSpec.describe Rspec::Generators::GeneratorsGenerator, :type => :generator do
RSpec.describe Rspec::Generators::GeneratorGenerator, :type => :generator do
setup_default_destination

describe "generator specs" do
Expand Down