Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generator spec generator #2217

Merged
merged 8 commits into from Jan 22, 2020
Merged

Fix generator spec generator #2217

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b69597
Properly Rename Generator Directory
joel Dec 3, 2019
439feed
Properly Rename Generator
joel Dec 3, 2019
f765be6
Fix Generate Generator Spec
joel Dec 3, 2019
2ae4d21
Do Not Generate Spec By Default
joel Dec 3, 2019
3553463
Add feature spec when generating generator
benoittgt Jan 20, 2020
4a8e2f5
Their is no need to clean files generated by rails command
benoittgt Jan 20, 2020
9dc2924
Rephrase few sentences of feature spec
benoittgt Jan 20, 2020
41a38fa
Rails generate generator command create spec by default
benoittgt Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions features/generator_specs/generator_specs.feature
View file
Open in desktop
@@ -0,0 +1,28 @@
Feature: Generator spec

RSpec spec(s) can be generated when generating application components. For instance, `rails generate model` will also generate an RSpec spec file for the model but you can also write your own generator. See [customizing your workflow](https://guides.rubyonrails.org/generators.html#customizing-your-workflow)

Scenario: Use custom generator without '--generator-specs' arg
When I run `bundle exec rails generate generator my_generator`
Then the features should pass
Then the output should contain:
"""
create lib/generators/my_generator
create lib/generators/my_generator/my_generator_generator.rb
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
"""

Scenario: Use custom generator with '--generator-specs' arg
When I run `bundle exec rails generate generator my_generator --generator-specs`
Then the features should pass
Then the output should contain:
"""
create lib/generators/my_generator
create lib/generators/my_generator/my_generator_generator.rb
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
create spec/generator/my_generators_generator_spec.rb
"""
2 changes: 1 addition & 1 deletion ...s/rspec/generators/generator_generator.rb → ...rs/rspec/generator/generator_generator.rb
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
module Rspec
module Generators
# @private
class GeneratorsGenerator < Base
class GeneratorGenerator < Base
class_option :generator_specs, type: :boolean, default: false, desc: "Generate generator specs"

def generate_generator_spec
Expand Down
0 ...ec/generators/templates/generator_spec.rb → ...pec/generator/templates/generator_spec.rb
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ec/generators/generator_generator_spec.rb → ...pec/generator/generator_generator_spec.rb
View file
Open in desktop
@@ -1,7 +1,7 @@
require 'generators/rspec/generators/generator_generator'
require 'generators/rspec/generator/generator_generator'
require 'support/generators'

RSpec.describe Rspec::Generators::GeneratorsGenerator, :type => :generator do
RSpec.describe Rspec::Generators::GeneratorGenerator, :type => :generator do
setup_default_destination

describe "generator specs" do
Expand Down