[experimental] Drop support of Ruby < 2.2 & Rails < 5.2 #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.8.5 fails hard `rake` locally with:
rm config/application.rb
bin/rake app:template LOCATION='../../example_app_generator/generate_stuff.rb'
rake aborted!
LoadError: dlopen(/Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri/nokogiri.bundle, 9): Library not loaded: /Users/pirj/.rvm/rubies/ruby-2.5.3/lib/libruby.2.5.dylib
Referenced from: /Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri/nokogiri.bundle
Reason: image not found - /Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri/nokogiri.bundle
/Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri.rb:32:in `require'
...
Caused by:
LoadError: cannot load such file -- nokogiri/2.5/nokogiri
/Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri.rb:30:in `require'
/Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/nokogiri-1.8.5/lib/nokogiri.rb:30:in `<top (required)>'
/Users/pirj/source/rspec-dev/repos/bundle/ruby/2.5.0/gems/loofah-2.4.0/lib/loofah.rb:4:in `require'
1.9.1 supports Ruby 2.1+.
|
The only failure is YARD on JRuby mistakenly takes gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => 'master'for a reference. Appreciate any guidance here. I'm getting a weird PS |
RuboCop 0.77 only supports 2.3, support for 2.2 was dropped in 0.69
|
Questions/TODO: Is it possible to get rid of this? # We need to copy this method from Thor for older Rails versions
def comment_lines(path, flag, *args)Evaluate numerous ::ActiveRecord::Migration.respond_to?(:check_pending!)I18n.enforce_available_locales = true if I18n.respond_to?(:enforce_available_locales)Simplify |
pirj
changed the title
|
I seem to recall the original discussion was to drop support for 4.x in 4, but not 5.x, leaving that for later, I know thats not what the RFC says, but basically kicking out all of the previously supported rails versions at once is a bit much. |
|
See #2071 for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Rails' support policy, Rails dropped all support for 5.0/5.1, even for severe security issues.
This comment mentioned that we planned to keep support for 5.0.
Another comment mentioning plans to drop 4.2 support.
From Versioning Strategy RFC:
This pull request has some rough edges, but I can iron it out if you feel like dropping support for < 5.2 is the way to go.