Add a reproduction case for #2242 #2253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed a cucumber tag. Sorry. |
To better mirror current Rails ActionDispatch::SystemTestCase. And resolve problems with inability to set ActiveJob queue type in systems example group.
benoittgt
force-pushed
the
add_reproduction_test_for_2232
branch
from
86493a8
to
8819b7a
Compare
This reverts commit 8819b7a.
|
Failing only on Rails6 (but oddly not on JRuby Rails6). Still feel free to let me know if it would be helpful if I made a standalone repro app (that passes with the code change, but fails without it, only on Rails6). This stuff definitely gets tricky, the Rails internals and how rspec tries to mimic them, and how they can differ in slightly different environments. |
|
No no it's ok. I revert your patch to see that test fails. Everything LGTM. |
|
Closing. I push on 2242. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge. This is for testing purpose for #2242