Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider the multibyte value in the method name of system test #2405

Closed
wants to merge 1 commit into from
+10 −1
Closed

Consider the multibyte value in the method name of system test #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rspec/rails/example/system_example_group.rb
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ def method_name
@method_name ||= [
self.class.name.underscore,
RSpec.current_example.description.underscore
].join("_").tr(CHARS_TO_TRANSLATE.join, "_")[0...200] + "_#{rand(1000)}"
].join("_").tr(CHARS_TO_TRANSLATE.join, "_").byteslice(0...200).scrub("") + "_#{rand(1000)}"
end

# Delegates to `Rails.application`.
Expand Down
9 changes: 9 additions & 0 deletions spec/rspec/rails/example/system_example_group_spec.rb
View file
Open in desktop
Expand Up @@ -16,6 +16,15 @@ module RSpec::Rails
expect(example.send(:method_name)).to start_with('method_name')
end
end

it "slices long method name - #{'あ'*100}" do
group = RSpec::Core::ExampleGroup.describe do
include SystemExampleGroup
end
example = group.new
group.hooks.run(:before, :example, example)
expect(example.send(:method_name).bytesize).to be <= 210
end
end

describe '#driver' do
Expand Down