Prevent collisions on let(:name) and let(:method_name) #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Feb 20, 2021
| @@ -0,0 +1,57 @@ | |||
| if __FILE__ =~ /^snippets/ | |||
There was a problem hiding this comment.
Just a note that we have no support for snippets in main, the code to run them is in rails-6-1-dev only.
But if CI passes on rails-6-1-dev, the patch should most possibly work for main, too.
There was a problem hiding this comment.
Is it easy-ish to backport that support?
There was a problem hiding this comment.
Should be easy. Looks like cherry-picking 040fecc and accepting the removed lines from Gemfile should do it.
benoittgt
approved these changes
Feb 20, 2021
Snippet is a self-contained example that defines the configuration, Rails project code and specs to run. Snippets: - allow for clean separation between different snippets - work quite fast - reuse the already installed gems that specs and Cukes use - do not litter - do not depend on other parts of the build In theory snippets retain the ability to use generators and arbitrary commands, but it makes the case under test less evident. Co-authored-by: Benoit Tigeot <benoit@hopsandfork.com>
Prevent collisions on let(:name) and let(:method_name)
pirj
force-pushed
the
let-name-collision
branch
from
094b6f1
to
073daad
Compare
|
Cherry-picked along with Changelog changes. Let's see if snippets are being run. |
|
Nice |
This was referenced Mar 7, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2461 for main