Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method name truncation for multibyte strings (redux) #2487

Merged
merged 3 commits into from Mar 17, 2021
Merged

Fix method name truncation for multibyte strings (redux) #2487

merged 3 commits into from Mar 17, 2021

Commits on Mar 17, 2021

  1. Consider the multibyte value in the method name of system test 

    `String#[]` returns a value that considers multibyte value. But some
file systems use byte for maximum filename length. So if applications
use that file system and multibyte value to a method name, currently
check doesn't work expected.

This PR fixes to use `String#byteslice` instead of `String#[]`. Also,
added `String#scrub` to avoid generating an invalid byte sequence.
    @y-yagi @JonRowe
    y-yagi authored and JonRowe committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    ee7e94a View commit details
    Browse the repository at this point in the history

  2. Improve multibyte spec to not use the example itself

    @JonRowe
    JonRowe committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    11cc658 View commit details
    Browse the repository at this point in the history

  3. Changelog for #287

    @JonRowe
    JonRowe committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    9aa49b0 View commit details
    Browse the repository at this point in the history