Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix have_enqueued_mail for Rails 7 and argument matching #2546

Merged
merged 10 commits into from Jan 10, 2022
Merged

Fix have_enqueued_mail for Rails 7 and argument matching #2546

merged 10 commits into from Jan 10, 2022

Commits on Jan 10, 2022

  1. Change HaveEnqueuedEmail to work as usual in Rails 6

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    50e2c72 View commit details
    Browse the repository at this point in the history

  2. Add missing relish documentation for parameter matching

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    7adcef2 View commit details
    Browse the repository at this point in the history

  3. Ensure ActionMailer::MailDeliveryJob is defined

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1092437 View commit details
    Browse the repository at this point in the history

  4. Silence rubocop for HaveEnqueuedMail class length

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    54d9692 View commit details
    Browse the repository at this point in the history

  5. Split all syntax in different examples

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    84ac4f8 View commit details
    Browse the repository at this point in the history

  6. Clarify examples with better params usage

    @fabn @pirj
    fabn authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    08d92ce View commit details
    Browse the repository at this point in the history

  7. Add compatibility for have_enqueued_mail (rails 7) 

    1. ActionMailer::DeliveryJob does not exist anymore
2. ActionMailer::Parameterized::DeliveryJob

According to my research they have both been superseeded by ActionMailer::MailDeliveryJob

Closes #2531
    @mhenrixon @pirj
    mhenrixon authored and pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    ed71aed View commit details
    Browse the repository at this point in the history

  8. Fix unified mailer args

    @pirj
    pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1dbacd7 View commit details
    Browse the repository at this point in the history

  9. Fix system spec spec on Rails 7 

    ActionPack is checking `instance_created?` now, and it was `false`, so
`take_screenshot` was not called.

```
def take_failed_screenshot
  take_screenshot if failed? && supports_screenshot? && Capybara::Session.instance_created?
end
```

rails/rails@1dfcffb
    @pirj
    pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a9cbac6 View commit details
    Browse the repository at this point in the history

  10. Add Changelog entry

    @pirj
    pirj committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    dd48c6b View commit details
    Browse the repository at this point in the history