Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup have_enqueued_job matcher on job retries #2573

Merged
merged 4 commits into from Apr 28, 2023
Merged

Fixup have_enqueued_job matcher on job retries #2573

merged 4 commits into from Apr 28, 2023

Commits on Apr 28, 2023

  1. Fixup have_enqueued_job matcher on job retries 

    Previously we were checking only job counts, so if one job was
performed and one job was added - matcher failed. Check by unique
id (`#hash`) instead.
We cannot use `job['job_id']` here, because job retains `job_id` on
retry.

Also we need to count jobs before & after because multiple
`#perform_later` in rails-6.0 create jobs with the same `#hash`, at
least in some cases, using `:test` AJ adapter.
    @ojab @pirj
    ojab authored and pirj committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ea072de View commit details
    Browse the repository at this point in the history

  2. Simplify the have_enqueued_job implementation

    @pirj
    pirj committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    efa83dc View commit details
    Browse the repository at this point in the history

  3. Add a spec for one job performed and one enqueued

    @pirj
    pirj committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    00bd256 View commit details
    Browse the repository at this point in the history

  4. Add changelog for rspec#2573

    @pirj
    pirj committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    47f15d2 View commit details
    Browse the repository at this point in the history