Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ActionView::PathSet immutability and strict type casting in Rails 7.1 #2631

Merged
merged 2 commits into from Oct 28, 2022
Merged

Handle ActionView::PathSet immutability and strict type casting in Rails 7.1 #2631

merged 2 commits into from Oct 28, 2022

Commits on Oct 28, 2022

  1. Don't mutate ActionView::PathSet 

    Follows
rails/rails@0371317.

ActionView::PathSet no longer responds to unshift or push. We could copy
the new implementation, but we've chosen to delegate to it instead.

Co-authored-by: Iliana Hadzhiatanasova <me@iliana.dev>
    @eugeneius @ilianah
    eugeneius and ilianah committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7c480d6 View commit details
    Browse the repository at this point in the history

  2. Make ResolverDecorator a subclass of ActionView::Resolver 

    Follows
rails/rails@e65d41a.

ActionView::PathSet now rejects resolvers unless they inherit from
ActionView::Resolver, so ResolverDecorator must do so. By removing all
inherited methods, we ensure that method_missing will still intercept
all method calls.

Co-authored-by: Iliana Hadzhiatanasova <me@iliana.dev>
    @eugeneius @ilianah
    eugeneius and ilianah committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    a226c6b View commit details
    Browse the repository at this point in the history