Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .dropdown-item wrapped in <li> tags #306

Merged
merged 2 commits into from Apr 15, 2021
Merged

Conversation

cpsievert
Copy link
Collaborator

Ports twbs/bootstrap#33649 into the v4.6.0 release.

This'll allow shiny to use the same HTML structure for tabset dropdowns by requiring bslib (>= 0.2.4.9003)

@cpsievert cpsievert requested a review from wch April 15, 2021 15:44
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What's the change in sysdata.rda?

@cpsievert
Copy link
Collaborator Author

cpsievert commented Apr 15, 2021

An internal Google Fonts database (used for lookup inside the real-time themer when fonts are entered)

@cpsievert cpsievert merged commit e09af88 into master Apr 15, 2021
@cpsievert cpsievert deleted the li-dropdown-patch branch April 15, 2021 16:08
@wch
Copy link
Collaborator

wch commented Apr 15, 2021

Opaque changes like that make me think we should reinstate #294. The package size increased by only 26kB in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants