Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .col_names param to cols_label() #848

Closed
wants to merge 6 commits into from

Conversation

jmbarbone
Copy link

Resolves #830

A few checks are completed:

  • .col_names defaults to NULL
  • If not NULL, ... and .list should not have length()
  • .col_names must be the same length as the colnames from the original data
  • .col_names should not have names -- gives a warning as the names would be overwritten and vector is expected to be in order

Local tests didn't show any conflicts with this

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2021

CLA assistant check
All committers have signed the CLA.

@rich-iannone rich-iannone requested review from rich-iannone and removed request for jcheng5 September 22, 2022 14:50
@rich-iannone
Copy link
Member

Thanks for the PR, but after a pretty long think about this one, I decided that this might be potentially difficult for the user during iteration; columns could be moved around (by gt or through the API), and columns could get used for the stub or as groups. At that point, it's hard to keep track of the original column order for renaming. But the next best thing to this is probably the .list argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

character vector for column labels?
3 participants