Skip to content

Commit

Permalink
Merge pull request #87 from rstudio/jon/fix
Browse files Browse the repository at this point in the history
'-buildvcs=false' for temporary build fix
  • Loading branch information
jonyoder committed May 3, 2022
2 parents b678764 + 566f478 commit 30c645c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/github-actions-ci.yml
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17
go-version: 1.18

- name: Checkout code
uses: actions/checkout@v2
Expand Down
10 changes: 9 additions & 1 deletion justfile
Expand Up @@ -52,14 +52,22 @@ vet:
# Builds Go code natively.
build:
cd examples && \
go build -o ../out/ ./...
go build -buildvcs=false -o ../out/ ./...

# run linters
lint:
./scripts/fmt-check.sh
./scripts/header-check.sh
./scripts/test-wiring.sh

# Opens a shell in the dev docker container.
bash:
docker run {{ interactive }} --rm \
-v {{justfile_directory()}}/:/build \
-e GOCACHE=/platform-lib/.go-cache \
-w /build \
rstudio/platform-lib:lib-build /bin/bash

# Builds Go code using docker. Useful when using a MacOS or Windows native IDE. First,
# run `just build-build-env' to create the docker image you'll need.
build-docker:
Expand Down
2 changes: 1 addition & 1 deletion scripts/test.sh
Expand Up @@ -11,7 +11,7 @@ DEF_TEST_ARGS=${DEF_TEST_ARGS:--short}
for MODULE in ${MODULES}; do
cd ${MODULE}

go test ${DEF_TEST_ARGS} ${TEST_ARGS[*]}
go test -buildvcs=false ${DEF_TEST_ARGS} ${TEST_ARGS[*]}
result=$?
if [[ $result -ne 0 ]]; then
__EXITCODE=$result
Expand Down

0 comments on commit 30c645c

Please sign in to comment.