Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'-buildvcs=false' for temporary build fix #87

Merged
merged 3 commits into from
May 3, 2022
Merged

'-buildvcs=false' for temporary build fix #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0240ec8
'-buildvcs=false' for temporary build fix
jonyoder May 3, 2022
cf25920
Update GHA to Go 1.18; add 'bash' justfile target
jonyoder May 3, 2022
566f478
Use '-buildvcs=false' in test.sh
jonyoder May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/github-actions-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17
go-version: 1.18

- name: Checkout code
uses: actions/checkout@v2
Expand Down
10 changes: 9 additions & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,22 @@ vet:
# Builds Go code natively.
build:
cd examples && \
go build -o ../out/ ./...
go build -buildvcs=false -o ../out/ ./...

# run linters
lint:
./scripts/fmt-check.sh
./scripts/header-check.sh
./scripts/test-wiring.sh

# Opens a shell in the dev docker container.
bash:
docker run {{ interactive }} --rm \
-v {{justfile_directory()}}/:/build \
-e GOCACHE=/platform-lib/.go-cache \
-w /build \
rstudio/platform-lib:lib-build /bin/bash

# Builds Go code using docker. Useful when using a MacOS or Windows native IDE. First,
# run `just build-build-env' to create the docker image you'll need.
build-docker:
Expand Down
2 changes: 1 addition & 1 deletion scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ DEF_TEST_ARGS=${DEF_TEST_ARGS:--short}
for MODULE in ${MODULES}; do
cd ${MODULE}

go test ${DEF_TEST_ARGS} ${TEST_ARGS[*]}
go test -buildvcs=false ${DEF_TEST_ARGS} ${TEST_ARGS[*]}
result=$?
if [[ $result -ne 0 ]]; then
__EXITCODE=$result
Expand Down