protect R objects cached for data viewer #14657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
force-pushed
the
bugfix/data-viewer-observed-sexp
branch
from
6e7551a
to
1314ef3
Compare
kevinushey
changed the title
kevinushey
commented
May 14, 2024
| client <- remote$client | ||
|
|
||
| # https://github.com/rstudio/rstudio/pull/14657 | ||
| test_that("we can use the data viewer with temporary R expressions", { |
There was a problem hiding this comment.
Not sure if there's a more appropriate test, but at least this exercises the underlying code.
kevinushey
commented
May 15, 2024
| @@ -448,9 +481,6 @@ | |||
| .rs.setVar("automation.client", client) | |||
| .rs.setVar("automation.sessionId", sessionId) | |||
|
|
|||
| # Navigate the page to RStudio Server. | |||
| client$Page.navigate("http://localhost:8787") | |||
There was a problem hiding this comment.
No longer necessary as we now point the browser directly at the running RStudio Server instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Addresses #14643.
Approach
Now that we try to introspect the contents of the observed R object shown in the data viewer, we need to protect that object from the GC.
Automated Tests
A basic automation test is included, but unfortunately is not sufficient to capture the underlying crash due to the stochastic nature of the problem.
QA Notes
N/A
Documentation
N/A
Checklist
NEWS.md