Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-node.sh: NODE_FILENAME #352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update install-node.sh: NODE_FILENAME #352

wants to merge 2 commits into from

Conversation

adelmofilho
Copy link

When I tried to install the node through this script on my raspberry, independent of the chosen NODE_SHA256 the downloaded node was the same because of the NODE_FILENAME definition, that was hold on linux-x64. With this change, it´s more explicit the need for select the right distribution - This change has revelance once the number of unsucess on installing shiny server on raspberry is high, in general because of this issue.

When I tried to install the node through this script on my raspberry, independent of the chosen NODE_SHA256 the downloaded node was the same because of the NODE_FILENAME definition, that was hold on linux-x64. With this change, it´s more explicit the need for select the right distribution - This change has revelance once the number of unsucess on installing shiny server on raspberry is high, in general because of this issue.
Update install-node.sh: NODE_FILENAME
@ConorIA
Copy link

ConorIA commented Jul 7, 2018

Instead of opening a new PR, can I make a suggestion here:

Lines 8-9 could be replaced by:

case $(uname -m) in
    "x86_64" )
        NODE_SHA256=08e2fcfea66746bd966ea3a89f26851f1238d96f86c33eaf6274f67fce58421a
        NODE_DIST=x64
        ;;
    "armv7l" )
        NODE_SHA256=7a2bb6e37615fa45926ac0ad4e5ecda4a98e2956e468dedc337117bfbae0ac68
        NODE_DIST=armv7l
        ;;
esac

Tested on Rasperry Pi 3 (Rasabian) and 64-bit Manjaro Linux.

Although it looks like there is a merge conflict that needs to be resolved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants