Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user an option to run shiny-server as root #391

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Give user an option to run shiny-server as root #391

wants to merge 17 commits into from

Conversation

haobibo
Copy link

@haobibo haobibo commented Mar 5, 2019

Currently, if the user runs the process of shiny-server in root and defines run_as to root, the shiny-server will abort.
It is possible (and secure) to allow users to run the process in root and run_as root?

@haobibo
Copy link
Author

haobibo commented Mar 5, 2019

@jcheng5 will appreciate it if you can provide any feedback/comments!

@jcheng5
Copy link
Member

jcheng5 commented Apr 17, 2019

I can't in good conscience accept this--the risks are so huge. Is there a reason you can't run as a different user?

@haobibo
Copy link
Author

haobibo commented Apr 17, 2019

Thank you @jcheng5 for your feedback!

I'm running shiny-server inside a Docker container, which isolates all environment inside the container: both file system and processes:https://github.com/QPod/docker-images

I chose to use the root user inside docker for simplicity reasons, where a user can do everything inside the container, and risks are isolated/controlled by docker.

I understand there is un-ignorable risk to run shiny-server as the root user.
While giving users an option can be helpful to users who intended to run shiny-server as root.
Here are some reference cases which provide an --allow-root in other software/programs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants