Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve NAs in selectInput() (addresses Issue #2884) #3594

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

d-morrison
Copy link

@d-morrison d-morrison commented Feb 26, 2022

This PR attempts to address #2884; glad to revise as needed! In particular, I'm not sure how to update shiny.min.js, so I have only tested my changes with options("shiny.minified" = FALSE)

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@d-morrison d-morrison changed the title attempt to solve https://github.com/rstudio/shiny/issues/2884 return NAs from selectInput() Feb 26, 2022
@d-morrison d-morrison changed the title return NAs from selectInput() preserve NAs in selectInput() Mar 9, 2022
@d-morrison d-morrison changed the title preserve NAs in selectInput() preserve NAs in selectInput() (addresses Issue #2884) Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants