Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show renderDataTable deprecation message by default #3718

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hedsnz
Copy link
Contributor

@hedsnz hedsnz commented Oct 28, 2022

Related to #3627.

  • shiny::renderDataTable has been deprecated since shiny 0.11.1, but the deprecation warning was only shown in dev mode.
  • This PR turns on that deprecation message by default.
  • Increasing visibility of this change is the first step toward eventually hard-deprecating shiny::renderDataTable and shiny::dataTableOutput in favour of the DT equivalents, allowing shiny to remove its dependency on DataTables.

@jonthegeek
Copy link

The description of "Superseded" might make this difficult (see #3627 (comment) ).

@jcheng5 jcheng5 force-pushed the renderdatatable-deprecation branch from de8153c to acbd1ed Compare January 6, 2023 01:20
@jcheng5
Copy link
Member

jcheng5 commented Jan 6, 2023

Hmmm, I used the GitHub button to rebase the branch against main and now CI is failing.

Edit: Fixed, the problem was with the GHA workflow, nothing to do with this PR.

@hedsnz
Copy link
Contributor Author

hedsnz commented Jul 5, 2023

@jcheng5 Any update on this, and/or #3627 in general?

@raulbla
Copy link

raulbla commented Sep 7, 2023

Is this PR still ongoing?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jcheng5
❌ hedsnz
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants