Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure logged-in user matches when handling session-specific routes #3766

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ensure logged-in user matches when handling session-specific routes #3766

wants to merge 3 commits into from

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jan 13, 2023 •
edited

Mitigation for #3748, see that issue for more information.

TODO

  • Unit test
  • Version bump and NEWS

Testing notes

  1. Install Shiny from this branch.
  2. Deploy the download example app to ShinyApps.io.
  3. From the ShinyApps.io dashboard, mark the deployed app as requiring login, and authorize two different users.
  4. Access the deployed app via a browser (logging in if necessary).
  5. Right-click the Download button and copy the link.
  6. From a second browser, access the app again, this time logging in as the other user.
  7. Paste the link from step 5 into the second browser's URL bar and press Enter.

Before this PR, the download would succeed. After this PR, the download returns 404.

@jcheng5 jcheng5 requested a review from wch January 13, 2023 01:32
wch
wch reviewed Jan 13, 2023
View reviewed changes
R/shiny.R Outdated Show resolved Hide resolved
@jcheng5 jcheng5 requested a review from wch February 13, 2023 17:30
@jcheng5
Copy link
Member Author

jcheng5 commented Feb 13, 2023

Barret said to ignore the failing r-devel check for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch Awaiting requested review from wch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcheng5 @wch