Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install things as necessary from shinycoreci r-universe #260

Merged
merged 75 commits into from
May 17, 2024
Merged

Install things as necessary from shinycoreci r-universe #260

merged 75 commits into from
May 17, 2024

Conversation

schloerke
Copy link
Contributor

@schloerke schloerke commented Mar 12, 2024 •
edited

Install dependencies as necessary when testing apps. This should revive older R versions when testing!

Very cool to see that old windows runs couldn't test 063 due to install failures!

  • Figure out why old macos is not finishing.
    • I could not figure it out. Am punting as it's older R versions on macOS
  • Followup PR - Fix tests on all apps; Add skip statements
  • Make sure ubuntu docker can build!
  • Followup PR - Add support for macOS brew dependencies. (Or just hard code install them!)

schloerke and others added 30 commits March 12, 2024 10:06
@schloerke
First pass at installing less things and install apps deps on demand …
74ab363 
…while testing
@schloerke
Code feedback
1ea2d11
@schloerke
checks
7509a52
@schloerke
Use resolve_libpath(local_pkgs=) for clearer intent
b58c1f2
@schloerke
Use actions/checkout@v4, not @v3
f430f2c
@schloerke
Remove install step
35f3822
@schloerke
Restructure matrix to be a shotgun
c055d24
@schloerke
Remove slack integration
d7b613a
@schloerke
fix snaps
700ec5d
@schloerke
Fix readme
0436cf8
@schloerke
Add app to proove that pkgs are installed
642c336
@schloerke
Add attempt_to_install_universe() method
38dc962
@schloerke
Use new shinyverse install method
582c8ae
@schloerke
Generate apps deps (GitHub Actions)
ba35e56
@schloerke
Fix broken test
4487d9b
@schloerke
fix snaps
25c8744
@schloerke
Update step dep to remove node16 warning
c89ecda
@schloerke
Remove gha-adjust-packages-to-install.R script
1703e7a
@schloerke
Update apps-test-os.yml
a972c29
@schloerke
Suppress output when installing first time in test_in_local
63a6511
@schloerke
Diagnostics
be8fb26
@schloerke
Try custom installation of shinyverse
10f6fa5
@schloerke
Generate apps deps (GitHub Actions)
6ba6fef
@schloerke
Make the shinyverse the first cran repo. Add rspm afterwards
52e9bae
@schloerke
Merge branch 'install_all_the_things' of https://github.com/rstudio/s…
e7f5d7a 
…hinycoreci into install_all_the_things
@schloerke
Update action.yaml
7888dc6
@schloerke
Update action.yaml
a39b86c
@schloerke
Do not install to new lib on CI; Avoid full double installation of co…
767786b 
…re packages
@schloerke
Remove unused files
47c8ca1
@schloerke
Fix typo
2a7f84c
cpsievert
cpsievert reviewed May 17, 2024
View reviewed changes
README.Rmd Outdated Show resolved Hide resolved
R/deploy-apps.R Outdated Show resolved Hide resolved
R/install-path.R Outdated Show resolved Hide resolved
inst/apps/000-pkg-versions/app.R Show resolved Hide resolved
@schloerke
Copy link
Contributor Author

🤞

@schloerke schloerke merged commit 2bdb36e into main May 17, 2024
29 of 30 checks passed
@schloerke schloerke deleted the install_all_the_things branch May 17, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @cpsievert