Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to React 18 #2595

Merged
merged 55 commits into from
Oct 27, 2022
Merged

Adapt to React 18 #2595

merged 55 commits into from
Oct 27, 2022

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jul 16, 2022

What's Changed

Beta version released

npm i rsuite@next

Examples

https://codesandbox.io/s/toaster-with-react-18-sql375
https://codesandbox.io/s/toaster-with-react-17-7vw790

@vercel
Copy link

vercel bot commented Jul 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 11:20AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Oct 25, 2022 at 11:20AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d156629:

Sandbox Source
rsuite-tp-ci Configuration
toaster with react 18 PR
toaster with react 17 PR

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Base: 85.65% // Head: 85.58% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (d156629) compared to base (c57579a).
Patch coverage: 88.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   85.65%   85.58%   -0.08%     
==========================================
  Files         297      299       +2     
  Lines        9140     9218      +78     
  Branches     2588     2611      +23     
==========================================
+ Hits         7829     7889      +60     
- Misses        685      694       +9     
- Partials      626      635       +9     
Flag Coverage Δ
ChromeCi 85.51% <87.73%> (-0.11%) ⬇️
Firefox 85.50% <87.73%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Overlay/OverlayTrigger.tsx 66.42% <ø> (ø)
src/Picker/PickerOverlay.tsx 95.83% <ø> (ø)
src/Picker/PickerToggle.tsx 96.25% <ø> (ø)
src/Picker/PickerToggleTrigger.tsx 100.00% <ø> (ø)
src/Tree/Tree.tsx 100.00% <ø> (ø)
src/Whisper/Whisper.tsx 100.00% <ø> (ø)
src/utils/treeUtils.ts 70.37% <ø> (ø)
src/Navbar/NavbarDropdownMenu.tsx 78.57% <33.33%> (-5.43%) ⬇️
src/Cascader/DropdownMenu.tsx 89.55% <50.00%> (ø)
src/MultiCascader/DropdownMenu.tsx 89.39% <50.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@SevenOutman SevenOutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is containing conflicts

@simonguo
Copy link
Member Author

Release rsuite@5.19.0-beta.5

npm i rsuite@next

* build(deps): bump next to 12.1.6 from 12.1.0

* docs: use react-select instead of react-text-mask
@simonguo
Copy link
Member Author

Release rsuite@5.20.0-beta.6

npm i rsuite@next

* fix(pickers): fix styling issues with virtualized lists

* style: code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants