Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the color contrast of form controls in disabled state #3809

Merged
merged 3 commits into from
May 17, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented May 15, 2024

Light

Before After
image image

Dark

Before After
image image

High contrast

Before After
image image

Copy link

codesandbox bot commented May 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:08am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 7:08am

Copy link

codesandbox-ci bot commented May 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@simonguo simonguo requested a review from LeightonYao May 15, 2024 05:04
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (a384bd0) to head (01680bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
- Coverage   93.87%   93.86%   -0.01%     
==========================================
  Files         662      662              
  Lines       22872    22854      -18     
  Branches     3105     3099       -6     
==========================================
- Hits        21471    21453      -18     
  Misses        711      711              
  Partials      690      690              
Flag Coverage Δ
ChromeCi 93.82% <98.07%> (-0.01%) ⬇️
Firefox 93.26% <78.84%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant