Don't call outer run_test!
API requests inside nested context
#652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using a nested RSpec
context
, the outerrun_test!
cause unexpected API calls.Solution
Avoid touching the
before
duringrun_test!
because that causes the API calls to be inherited.Related Issues
I searched for issues in GitHub but was not able to find any mention of this problem.
Checklist
context
Steps to Test or Reproduce
Run the changed specs without the change to example_group_helpers.rb and you'll have a
.count
of 2: one for line 23 and a second for line 28.