Apply CGI.escape to non-array non-form values #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHawley
reviewed
Feb 27, 2024
| @@ -174,7 +174,7 @@ def build_query_string_part(param, value, swagger_doc) | |||
| return "#{escaped_name}=" + value.to_a.flatten.map{|v| CGI.escape(v.to_s) }.join(separator) | |||
| end | |||
| else | |||
| return "#{name}=#{value}" | |||
| return "#{name}=#{CGI.escape(value)}" | |||
There was a problem hiding this comment.
CGI.escape(value.to_s)
The to_s was implicit before.
|
#725 fixes the same bug but does the change I suggested instead. It should be used instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A string query param described in an rswag integration spec gets escaped in
rspectests and doesn't get escaped in rswag non-dry run.Solution
Apply the same array and form escaping to everything else.
The changes I made are compatible with:
Checklist
Steps to Test or Reproduce
xthat is a string and contains a#, for example:?filter[description]=Order for #231